From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:39684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754522AbeEaLqQ (ORCPT ); Thu, 31 May 2018 07:46:16 -0400 Date: Thu, 31 May 2018 13:45:54 +0200 From: Greg Kroah-Hartman To: Sebastian Gottschall Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Timur Tabi , Bjorn Andersson , Linus Walleij , Sasha Levin Subject: Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering Message-ID: <20180531114553.GB11598@kroah.com> References: <20180528100240.256525891@linuxfoundation.org> <20180528100302.722883806@linuxfoundation.org> <7c34ccef-2fa8-8b53-2677-29f6fbe71a04@dd-wrt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7c34ccef-2fa8-8b53-2677-29f6fbe71a04@dd-wrt.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, May 31, 2018 at 01:21:56PM +0200, Sebastian Gottschall wrote: > Am 28.05.2018 um 12:05 schrieb Greg Kroah-Hartman: > > 4.16-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Bjorn Andersson > > > > [ Upstream commit a7aa75a2a7dba32594291a71c3704000a2fd7089 ] > > > > The base of the TLMM gpiochip should not be statically defined as 0, fix > > this to not artificially restrict the existence of multiple pinctrl-msm > > devices. > > > > Fixes: f365be092572 ("pinctrl: Add Qualcomm TLMM driver") > > Reported-by: Timur Tabi > > Signed-off-by: Bjorn Andersson > > Signed-off-by: Linus Walleij > > Signed-off-by: Sasha Levin > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/pinctrl/qcom/pinctrl-msm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > > @@ -818,7 +818,7 @@ static int msm_gpio_init(struct msm_pinc > > return -EINVAL; > > chip = &pctrl->chip; > > - chip->base = 0; > > + chip->base = -1; > > chip->ngpio = ngpio; > > chip->label = dev_name(pctrl->dev); > > chip->parent = pctrl->dev; > > this patch creates a regression for me. on ipq8064 the systems gpios now > start somewhere in the sky > > new layout > > lrwxrwxrwx��� 1 root���� root������������ 0 Jan� 1 00:00 gpiochip373 -> ../../devices/platform/soc/1b700000.pci/pci0001:00/0001:00:00.0/0001:01:00.0/gpio/gpiochip373 > lrwxrwxrwx��� 1 root���� root������������ 0 Jan� 1 00:00 gpiochip408 -> ../../devices/platform/soc/1b500000.pci/pci0000:00/0000:00:00.0/0000:01:00.0/gpio/gpiochip408 > lrwxrwxrwx��� 1 root���� root������������ 0 Jan� 1 00:00 gpiochip443 -> > ../../devices/platform/soc/800000.pinmux/gpio/gpiochip443 > > > before the patch > > lrwxrwxrwx��� 1 root���� root������������ 0 Jan� 1� 1970 gpiochip0 -> > ../../devices/platform/soc/800000.pinmux/gpio/gpiochip0 > lrwxrwxrwx��� 1 root���� root������������ 0 May 31 13:13 gpiochip442 -> ../../devices/platform/soc/1b700000.pci/pci0001:00/0001:00:00.0/0001:01:00.0/gpio/gpiochip442 > lrwxrwxrwx��� 1 root���� root������������ 0 May 31 13:13 gpiochip477 -> ../../devices/platform/soc/1b500000.pci/pci0000:00/0000:00:00.0/0000:01:00.0/gpio/gpiochip477 > > > this broke my userspace gpio handling. i can override this, but still it > doesnt look correct since there is a hole at the beginng likelly reserved by > unused arm gpios So does this mean that 4.17-rc is also broken for you? If so, this needs to be reverted there as well. Bjorn, any ideas? thanks, greg k-h