From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:39351 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754290AbeFLMqm (ORCPT ); Tue, 12 Jun 2018 08:46:42 -0400 From: Johan Hovold To: Borislav Petkov Cc: Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable , Denis Kirjanov , Mauro Carvalho Chehab Subject: [PATCH 1/2] EDAC: fix memleak in module init error path Date: Tue, 12 Jun 2018 14:43:34 +0200 Message-Id: <20180612124335.6420-1-johan@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: Make sure to use put_device() to free the initialised struct device so that resources managed by driver core also gets released in the event of a registration failure. Fixes: de3910eb79ac ("edac: change the mem allocation scheme to make Documentation/kobject.txt happy") Fixes: 2d56b109e3a5 ("EDAC: Handle error path in edac_mc_sysfs_init() properly") Cc: stable # 3.6 Cc: Denis Kirjanov Cc: Mauro Carvalho Chehab Signed-off-by: Johan Hovold --- drivers/edac/edac_mc_sysfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 7481955160a4..20374b8248f0 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -1075,14 +1075,14 @@ int __init edac_mc_sysfs_init(void) err = device_add(mci_pdev); if (err < 0) - goto out_dev_free; + goto out_put_device; edac_dbg(0, "device %s created\n", dev_name(mci_pdev)); return 0; - out_dev_free: - kfree(mci_pdev); + out_put_device: + put_device(mci_pdev); out: return err; } -- 2.17.1