From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:5709 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755193AbeFNMeR (ORCPT ); Thu, 14 Jun 2018 08:34:17 -0400 Date: Thu, 14 Jun 2018 15:34:13 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disallow interlaced modes on g4x DP outputs Message-ID: <20180614123413.GB20518@intel.com> References: <20180613160553.11664-1-ville.syrjala@linux.intel.com> <87o9gdzha5.fsf@intel.com> <87k1r1zh9a.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87k1r1zh9a.fsf@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jun 14, 2018 at 03:26:09PM +0300, Jani Nikula wrote: > On Thu, 14 Jun 2018, Jani Nikula wrote: > > On Wed, 13 Jun 2018, Ville Syrjala wrote: > >> From: Ville Syrj�l� > >> > >> Looks like interlaced DP output doesn't work on g4x either. Not all > >> that surprising considering we already established that interlaced > >> DP output is busted on VLV/CHV. > >> > >> Cc: stable@vger.kernel.org > >> Signed-off-by: Ville Syrj�l� > > > > Reviewed-by: Jani Nikula > > Oh, did you have a bug reference? No. Just noticed it on my own machine. > > > > > > > >> --- > >> drivers/gpu/drm/i915/intel_dp.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > >> index 40ffd9163175..6068986fd985 100644 > >> --- a/drivers/gpu/drm/i915/intel_dp.c > >> +++ b/drivers/gpu/drm/i915/intel_dp.c > >> @@ -1869,7 +1869,7 @@ intel_dp_compute_config(struct intel_encoder *encoder, > >> conn_state->scaling_mode); > >> } > >> > >> - if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) && > >> + if (HAS_GMCH_DISPLAY(dev_priv) && > >> adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) > >> return false; > >> > >> @@ -6351,7 +6351,7 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, > >> drm_connector_init(dev, connector, &intel_dp_connector_funcs, type); > >> drm_connector_helper_add(connector, &intel_dp_connector_helper_funcs); > >> > >> - if (!IS_VALLEYVIEW(dev_priv) && !IS_CHERRYVIEW(dev_priv)) > >> + if (!HAS_GMCH_DISPLAY(dev_priv)) > >> connector->interlace_allowed = true; > >> connector->doublescan_allowed = 0; > > -- > Jani Nikula, Intel Open Source Graphics Center -- Ville Syrj�l� Intel