From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39410 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754091AbeFRErh (ORCPT ); Mon, 18 Jun 2018 00:47:37 -0400 Date: Mon, 18 Jun 2018 06:47:33 +0200 From: Greg Kroah-Hartman To: Guenter Roeck Cc: Benjamin Gilbert , stable@vger.kernel.org Subject: Re: TCP receive windows broken in 4.14.48 Message-ID: <20180618044733.GA28706@kroah.com> References: <20180614210921.GA23356@trogon.sfo.coreos.systems> <20180614212029.GA27119@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180614212029.GA27119@roeck-us.net> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jun 14, 2018 at 02:20:29PM -0700, Guenter Roeck wrote: > On Thu, Jun 14, 2018 at 05:09:21PM -0400, Benjamin Gilbert wrote: > > Hi, > > > > 4.14.48 can cause abnormally small TCP receive windows when the sender is > > faster than the receiver; see https://github.com/coreos/bugs/issues/2457 for > > details. Reverting "tcp: avoid integer overflows in tcp_rcv_space_adjust()" > > fixes it. Backporting 02db55718d53 ("tcp: do not overshoot window_clamp in > > tcp_rcv_space_adjust()"), which is its parent commit upstream, also fixes > > it. > > > 02db55718d53 applies cleanly, so I would suggest we go along that route > instead of a revert. > > Greg - given that the problematic commit is in all stable releases, it would > probably make sense to apply 02db55718d53 to pre-4.14 kernels as well. It > does apply clean to all kernels all the way back to 3.18.y. Now done, thanks. greg k-h