From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([5.9.137.197]:51490 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933337AbeFRLcM (ORCPT ); Mon, 18 Jun 2018 07:32:12 -0400 Date: Mon, 18 Jun 2018 13:32:06 +0200 From: Borislav Petkov To: Johan Hovold Cc: Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, stable Subject: Re: [PATCH 2/2] EDAC: i7core: fix memleaks and use-after-free on probe and remove Message-ID: <20180618113205.GA24921@zn.tnic> References: <20180612124335.6420-1-johan@kernel.org> <20180612124335.6420-2-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180612124335.6420-2-johan@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Jun 12, 2018 at 02:43:35PM +0200, Johan Hovold wrote: > Make sure to free and deregister the addrmatch and chancounts devices > allocated during probe in all error paths. Also fix use-after-free in a > probe error path and in the remove success path where the devices were > being put before before deregistration. > > Fixes: 356f0a30860d ("i7core_edac: change the mem allocation scheme to make Documentation/kobject.txt happy") > Cc: stable # 3.6 > Cc: Mauro Carvalho Chehab > Signed-off-by: Johan Hovold > --- > drivers/edac/i7core_edac.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) Both applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.