From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-pg0-f67.google.com ([74.125.83.67]:33553 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752836AbeFTB6j (ORCPT
        <rfc822;stable@vger.kernel.org>); Tue, 19 Jun 2018 21:58:39 -0400
Date: Wed, 20 Jun 2018 10:58:34 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        linux-kernel@vger.kernel.org, "4 . 13+" <stable@vger.kernel.org>
Subject: Re: [PATCH] printk/nmi: Prevent deadlock when serializing NMI
 backtraces
Message-ID: <20180620015834.GD650@jagdpanzerIV>
References: <20180605124729.3vix5nlkjpjzdljx@pathway.suse.cz>
 <20180606051029.GA19211@tigerII.localdomain>
 <20180606103356.GB19211@tigerII.localdomain>
 <20180608104825.e7xoxteelaxnwx66@pathway.suse.cz>
 <20180618063738.GC27996@jagdpanzerIV>
 <20180618093917.qeaatnlqh5if6t3r@pathway.suse.cz>
 <20180618100718.GA555@jagdpanzerIV>
 <20180619075219.iq7ztwu43bn4uua7@pathway.suse.cz>
 <20180619082716.GD405@jagdpanzerIV>
 <20180619092304.6b6ba390@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180619092304.6b6ba390@gandalf.local.home>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On (06/19/18 09:23), Steven Rostedt wrote:
> > On (06/19/18 09:52), Petr Mladek wrote:
> > > On Mon 2018-06-18 19:07:18, Sergey Senozhatsky wrote:  
> > > > On (06/18/18 11:39), Petr Mladek wrote:
> > > > [..]
> > > > 
> > > > Hmm. Can't answer right now :)  
> > > 
> > > Please, let me know what name you would like ;-)  
> > 
> > :) Wow, it's hard. Maybe we can derive some bits from the ftrace_dump()
> > function name? Dunno... Does printk_dump_nmi_enter() sound terrible?
> > 
> > Maybe Steven has some opinions on this?
> > 
> 
> What exactly is the question?

Which one of these you'd prefer to see in ftrace_dump():

- printk_nmi_direct_enter() / printk_nmi_direct_exit()
- printk_chatty_nmi_enter() / printk_chatty_nmi_exit()
- printk_large_nmi_enter() / printk_large_nmi_exit()
- printk_dump_nmi_enter() / printk_dump_nmi_exit()

> Also, from a previous email in this thread, if you have to risk
> interleaved output to solve a deadlock, then just do that.

Yep.

	-ss