stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 03/17] arm64: dts: marvell: fix CP110 ICU node size
       [not found] <20180622151432.1566-1-miquel.raynal@bootlin.com>
@ 2018-06-22 15:14 ` Miquel Raynal
  2018-06-25 15:05   ` Gregory CLEMENT
  0 siblings, 1 reply; 3+ messages in thread
From: Miquel Raynal @ 2018-06-22 15:14 UTC (permalink / raw)
  To: Thomas Gleixner, Jason Cooper, Marc Zyngier, Catalin Marinas,
	Will Deacon, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
  Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel,
	Thomas Petazzoni, Antoine Tenart, Maxime Chevallier, Nadav Haklai,
	Haim Boot, Hanna Hawa, Miquel Raynal, stable

ICU size in CP110 is not 0x10 but at least 0x440 bytes long (from the
specification).

Fixes: 6ef84a827c37 ("arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K")
Cc: stable@vger.kernel.org
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
index 7dabe25f6774..1c6ff8197a88 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
@@ -149,7 +149,7 @@
 
 		CP110_LABEL(icu): interrupt-controller@1e0000 {
 			compatible = "marvell,cp110-icu";
-			reg = <0x1e0000 0x10>;
+			reg = <0x1e0000 0x440>;
 			#interrupt-cells = <3>;
 			interrupt-controller;
 			msi-parent = <&gicp>;
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3 03/17] arm64: dts: marvell: fix CP110 ICU node size
  2018-06-22 15:14 ` [PATCH v3 03/17] arm64: dts: marvell: fix CP110 ICU node size Miquel Raynal
@ 2018-06-25 15:05   ` Gregory CLEMENT
  2018-06-25 15:09     ` Miquel Raynal
  0 siblings, 1 reply; 3+ messages in thread
From: Gregory CLEMENT @ 2018-06-25 15:05 UTC (permalink / raw)
  To: Miquel Raynal
  Cc: Thomas Gleixner, Jason Cooper, Marc Zyngier, Catalin Marinas,
	Will Deacon, Andrew Lunn, Sebastian Hesselbarth, Rob Herring,
	Mark Rutland, devicetree, linux-arm-kernel, Thomas Petazzoni,
	Antoine Tenart, Maxime Chevallier, Nadav Haklai, Haim Boot,
	Hanna Hawa, stable

Hi Miquel,
 
 On ven., juin 22 2018, Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> ICU size in CP110 is not 0x10 but at least 0x440 bytes long (from the
> specification).
>
> Fixes: 6ef84a827c37 ("arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K")
> Cc: stable@vger.kernel.org
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

This patch was part of the last PR from arm-soc for Linus and should be
part of 4.18-rc3, so if there is new version you can drop it.

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> index 7dabe25f6774..1c6ff8197a88 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> @@ -149,7 +149,7 @@
>  
>  		CP110_LABEL(icu): interrupt-controller@1e0000 {
>  			compatible = "marvell,cp110-icu";
> -			reg = <0x1e0000 0x10>;
> +			reg = <0x1e0000 0x440>;
>  			#interrupt-cells = <3>;
>  			interrupt-controller;
>  			msi-parent = <&gicp>;
> -- 
> 2.14.1
>

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3 03/17] arm64: dts: marvell: fix CP110 ICU node size
  2018-06-25 15:05   ` Gregory CLEMENT
@ 2018-06-25 15:09     ` Miquel Raynal
  0 siblings, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2018-06-25 15:09 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Thomas Gleixner, Jason Cooper, Marc Zyngier, Catalin Marinas,
	Will Deacon, Andrew Lunn, Sebastian Hesselbarth, Rob Herring,
	Mark Rutland, devicetree, linux-arm-kernel, Thomas Petazzoni,
	Antoine Tenart, Maxime Chevallier, Nadav Haklai, Haim Boot,
	Hanna Hawa, stable

Hi Gregory,

On Mon, 25 Jun 2018 17:05:22 +0200, Gregory CLEMENT
<gregory.clement@bootlin.com> wrote:

> Hi Miquel,
>  
>  On ven., juin 22 2018, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> > ICU size in CP110 is not 0x10 but at least 0x440 bytes long (from the
> > specification).
> >
> > Fixes: 6ef84a827c37 ("arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>  
> 
> This patch was part of the last PR from arm-soc for Linus and should be
> part of 4.18-rc3, so if there is new version you can drop it.
> 

Sure, thanks for the reminder.

Miquèl

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-25 15:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20180622151432.1566-1-miquel.raynal@bootlin.com>
2018-06-22 15:14 ` [PATCH v3 03/17] arm64: dts: marvell: fix CP110 ICU node size Miquel Raynal
2018-06-25 15:05   ` Gregory CLEMENT
2018-06-25 15:09     ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).