From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:36015 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752337AbeF1CTs (ORCPT
        <rfc822;stable@vger.kernel.org>); Wed, 27 Jun 2018 22:19:48 -0400
Date: Thu, 28 Jun 2018 11:19:44 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/3] printk: Create helper function to queue deferred
 console handling
Message-ID: <20180628021944.GC481@jagdpanzerIV>
References: <20180627140817.27764-1-pmladek@suse.com>
 <20180627140817.27764-3-pmladek@suse.com>
 <20180628021603.GB481@jagdpanzerIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180628021603.GB481@jagdpanzerIV>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On (06/28/18 11:16), Sergey Senozhatsky wrote:
> 
> You can just call vprintk_emit(LOGLEVEL_SCHED) from vprintk_func(),
> then you don't need to factor out vprintk_deferred() and vprintk_emit().
> Any reason for that split?

My bad, no you can't. I forgot that for direct_nmi vprintk_func()
logbuf_lock is locked at the upper level - vprintk_func().

	-ss