From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59844 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753593AbeF1PdM (ORCPT ); Thu, 28 Jun 2018 11:33:12 -0400 Date: Thu, 28 Jun 2018 11:33:11 -0400 From: Mike Snitzer To: Bart Van Assche Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Ming Lei , Hannes Reinecke , Johannes Thumshirn , stable@vger.kernel.org Subject: Re: block: Fix cloning of requests with a special payload Message-ID: <20180628153311.GB17723@redhat.com> References: <20180627195518.13958-1-bart.vanassche@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180627195518.13958-1-bart.vanassche@wdc.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jun 27 2018 at 3:55pm -0400, Bart Van Assche wrote: > This patch avoids that removing a path controlled by the dm-mpath driver > while mkfs is running triggers the following kernel bug: > > kernel BUG at block/blk-core.c:3347! > invalid opcode: 0000 [#1] PREEMPT SMP KASAN > CPU: 20 PID: 24369 Comm: mkfs.ext4 Not tainted 4.18.0-rc1-dbg+ #2 > RIP: 0010:blk_end_request_all+0x68/0x70 > Call Trace: > > dm_softirq_done+0x326/0x3d0 [dm_mod] > blk_done_softirq+0x19b/0x1e0 > __do_softirq+0x128/0x60d > irq_exit+0x100/0x110 > smp_call_function_single_interrupt+0x90/0x330 > call_function_single_interrupt+0xf/0x20 > > > Fixes: f9d03f96b988 ("block: improve handling of the magic discard payload") > Signed-off-by: Bart Van Assche > Cc: Christoph Hellwig > Cc: Mike Snitzer > Cc: Ming Lei > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > Cc: Acked-by: Mike Snitzer