From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:43069 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934863AbeF2BwP (ORCPT ); Thu, 28 Jun 2018 21:52:15 -0400 Date: Fri, 29 Jun 2018 10:52:11 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Peter Zijlstra , Tetsuo Handa , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 0/3] printk: Deadlock in NMI regression Message-ID: <20180629015211.GB614@jagdpanzerIV> References: <20180627140817.27764-1-pmladek@suse.com> <20180628023902.GE481@jagdpanzerIV> <20180628105404.stnlihwzfgpsrl4f@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180628105404.stnlihwzfgpsrl4f@pathway.suse.cz> Sender: stable-owner@vger.kernel.org List-ID: On (06/28/18 12:54), Petr Mladek wrote: > > On Thu 2018-06-28 11:39:02, Sergey Senozhatsky wrote: > > On (06/27/18 16:08), Petr Mladek wrote: > > > > > > kernel/printk/printk.c | 57 +++++++++++++++++++++++++++----------------- > > > kernel/printk/printk_safe.c | 58 +++++++++++++++++++++++++++++---------------- > > > > Shall we just merge these two? > > Do you mean to merge files or the patches, please? Yeah... dunno. We now lock logbuf spinlock outside of printk.c, and we now have printk.c functions that have that "printk guts, must be called under logbuf lock" requirement and so on. I like when static things are static :) -ss