Re: [PATCH 4.9] iio:buffer: make length types match kfifo types

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Jun 18, 2018 at 08:58:27PM +0100, Ben Hutchings wrote:
> From: Martin Kelly <mkelly@xevo.com>
> 
> commit c043ec1ca5baae63726aae32abbe003192bc6eec upstream.
> 
> Currently, we use int for buffer length and bytes_per_datum. However,
> kfifo uses unsigned int for length and size_t for element size. We need
> to make sure these matches or we will have bugs related to overflow (in
> the range between INT_MAX and UINT_MAX for length, for example).
> 
> In addition, set_bytes_per_datum uses size_t while bytes_per_datum is an
> int, which would cause bugs for large values of bytes_per_datum.
> 
> Change buffer length to use unsigned int and bytes_per_datum to use
> size_t.
> 
> Signed-off-by: Martin Kelly <mkelly@xevo.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> [bwh: Backported to 4.9:
>  - Drop change to iio_dma_buffer_set_length()
>  - Adjust filename, context]
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> ---
>  drivers/iio/buffer/kfifo_buf.c | 4 ++--
>  include/linux/iio/buffer.h     | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)

Thanks for this and the 4.4 backport, now queued up.

greg k-h