nfp: don't tell FW about the reserved buffer space

nfp: don't tell FW about the reserved buffer space

[Jakub Kicinski]

Hi!

Can we get the following backported to the 4.9 branch?

commit 9383b33771e566fa547daa2d09c6e0f1aaa298c3
Author: Jakub Kicinski <jakub.kicinski@netronome.com>
Date:   Thu Mar 2 15:26:20 2017 -0800

    nfp: don't tell FW about the reserved buffer space
    
    Since commit c0f031bc8866 ("nfp_net: use alloc_frag() and build_skb()")
    we are allocating buffers which have to hold both the data and skb to
    be created in place by build_skb().
    
    FW should only be told about the buffer space it can DMA to, that
    is without the build_skb() headroom and tailroom.  Note: firmware
    applications should validate the buffers against both MTU and
    free list buffer size so oversized packets would not pass through
    the NIC anyway.
    
    Fixes: c0f031bc8866 ("nfp: use alloc_frag() and build_skb()")
    Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

Thank you!

Re: nfp: don't tell FW about the reserved buffer space

[Greg KH]

On Fri, Jun 29, 2018 at 02:03:48PM -0700, Jakub Kicinski wrote:
> Hi!
> 
> Can we get the following backported to the 4.9 branch?
> 
> commit 9383b33771e566fa547daa2d09c6e0f1aaa298c3
> Author: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date:   Thu Mar 2 15:26:20 2017 -0800

Now applied, thanks.


greg k-h

Re: nfp: don't tell FW about the reserved buffer space

[Greg KH]

On Sun, Jul 01, 2018 at 04:49:54PM +0200, Greg KH wrote:
> On Fri, Jun 29, 2018 at 02:03:48PM -0700, Jakub Kicinski wrote:
> > Hi!
> > 
> > Can we get the following backported to the 4.9 branch?
> > 
> > commit 9383b33771e566fa547daa2d09c6e0f1aaa298c3
> > Author: Jakub Kicinski <jakub.kicinski@netronome.com>
> > Date:   Thu Mar 2 15:26:20 2017 -0800
> 
> Now applied, thanks.

And it breaks the build :(

Please provide a working patch if you want it in the stable release.
And always test these before asking.  Having patches break a build is
very annoying...

thanks,

greg k-h

Re: nfp: don't tell FW about the reserved buffer space

[Jakub Kicinski]

On Sun, Jul 1, 2018 at 9:05 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Jul 01, 2018 at 04:49:54PM +0200, Greg KH wrote:
>> On Fri, Jun 29, 2018 at 02:03:48PM -0700, Jakub Kicinski wrote:
>> > Hi!
>> >
>> > Can we get the following backported to the 4.9 branch?
>> >
>> > commit 9383b33771e566fa547daa2d09c6e0f1aaa298c3
>> > Author: Jakub Kicinski <jakub.kicinski@netronome.com>
>> > Date:   Thu Mar 2 15:26:20 2017 -0800
>>
>> Now applied, thanks.
>
> And it breaks the build :(
>
> Please provide a working patch if you want it in the stable release.
> And always test these before asking.  Having patches break a build is
> very annoying...

Sorry about this Greg! :(  I was looking at 4.10 tree for some reason.
And 4.10 is dead, obviously.