* [PATCH 1/5] ARM: dts: dra7: Disable metastability workaround for USB2
[not found] <1527584458-6257-1-git-send-email-rogerq@ti.com>
@ 2018-05-29 9:00 ` Roger Quadros
2018-07-02 11:05 ` Tony Lindgren
2018-05-29 9:00 ` [PATCH 2/5] ARM: dts: am57xx-idk: Enable dual role for USB2 port Roger Quadros
1 sibling, 1 reply; 3+ messages in thread
From: Roger Quadros @ 2018-05-29 9:00 UTC (permalink / raw)
To: tony; +Cc: linux-omap, devicetree, linux-kernel, Roger Quadros, [4.16+]
Disable the metastability workaround for USB2. The original
patch disabled the workaround on the wrong USB port.
Fixes: b8c9c6fa2002 ("ARM: dts: dra7: Disable USB metastability workaround for USB2")
Cc: <stable@vger.kernel.org> [4.16+]
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
arch/arm/boot/dts/dra7.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index f4ddd86..9cace9f 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1582,7 +1582,6 @@
dr_mode = "otg";
snps,dis_u3_susphy_quirk;
snps,dis_u2_susphy_quirk;
- snps,dis_metastability_quirk;
};
};
@@ -1610,6 +1609,7 @@
dr_mode = "otg";
snps,dis_u3_susphy_quirk;
snps,dis_u2_susphy_quirk;
+ snps,dis_metastability_quirk;
};
};
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/5] ARM: dts: am57xx-idk: Enable dual role for USB2 port
[not found] <1527584458-6257-1-git-send-email-rogerq@ti.com>
2018-05-29 9:00 ` [PATCH 1/5] ARM: dts: dra7: Disable metastability workaround for USB2 Roger Quadros
@ 2018-05-29 9:00 ` Roger Quadros
1 sibling, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2018-05-29 9:00 UTC (permalink / raw)
To: tony; +Cc: linux-omap, devicetree, linux-kernel, Roger Quadros, [4.16+]
Dual-role support was added in v4.12. We should be using
it for USB2 port on the am57xx-idk.
Cc: <stable@vger.kernel.org> [4.16+]
Reported-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
arch/arm/boot/dts/am571x-idk.dts | 4 ----
arch/arm/boot/dts/am572x-idk-common.dtsi | 4 ----
arch/arm/boot/dts/am57xx-idk-common.dtsi | 7 ++++++-
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/am571x-idk.dts b/arch/arm/boot/dts/am571x-idk.dts
index a255514..86301ae 100644
--- a/arch/arm/boot/dts/am571x-idk.dts
+++ b/arch/arm/boot/dts/am571x-idk.dts
@@ -65,10 +65,6 @@
};
};
-&omap_dwc3_2 {
- extcon = <&extcon_usb2>;
-};
-
&extcon_usb2 {
id-gpio = <&gpio5 7 GPIO_ACTIVE_HIGH>;
vbus-gpio = <&gpio7 22 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/am572x-idk-common.dtsi b/arch/arm/boot/dts/am572x-idk-common.dtsi
index c6d858b..784639d 100644
--- a/arch/arm/boot/dts/am572x-idk-common.dtsi
+++ b/arch/arm/boot/dts/am572x-idk-common.dtsi
@@ -57,10 +57,6 @@
};
};
-&omap_dwc3_2 {
- extcon = <&extcon_usb2>;
-};
-
&extcon_usb2 {
id-gpio = <&gpio3 16 GPIO_ACTIVE_HIGH>;
vbus-gpio = <&gpio3 26 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/am57xx-idk-common.dtsi b/arch/arm/boot/dts/am57xx-idk-common.dtsi
index 43cdf52..697cd1a 100644
--- a/arch/arm/boot/dts/am57xx-idk-common.dtsi
+++ b/arch/arm/boot/dts/am57xx-idk-common.dtsi
@@ -406,8 +406,13 @@
dr_mode = "host";
};
+&omap_dwc3_2 {
+ extcon = <&extcon_usb2>;
+};
+
&usb2 {
- dr_mode = "peripheral";
+ extcon = <&extcon_usb2>;
+ dr_mode = "otg";
};
&mmc1 {
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/5] ARM: dts: dra7: Disable metastability workaround for USB2
2018-05-29 9:00 ` [PATCH 1/5] ARM: dts: dra7: Disable metastability workaround for USB2 Roger Quadros
@ 2018-07-02 11:05 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2018-07-02 11:05 UTC (permalink / raw)
To: Roger Quadros; +Cc: linux-omap, devicetree, linux-kernel, [4.16+]
* Roger Quadros <rogerq@ti.com> [180529 02:03]:
> Disable the metastability workaround for USB2. The original
> patch disabled the workaround on the wrong USB port.
>
> Fixes: b8c9c6fa2002 ("ARM: dts: dra7: Disable USB metastability workaround for USB2")
> Cc: <stable@vger.kernel.org> [4.16+]
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Sorry for the delay, applying this one into omap-for-v4.18/fixes.
Regards,
Tony
> ---
> arch/arm/boot/dts/dra7.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index f4ddd86..9cace9f 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1582,7 +1582,6 @@
> dr_mode = "otg";
> snps,dis_u3_susphy_quirk;
> snps,dis_u2_susphy_quirk;
> - snps,dis_metastability_quirk;
> };
> };
>
> @@ -1610,6 +1609,7 @@
> dr_mode = "otg";
> snps,dis_u3_susphy_quirk;
> snps,dis_u2_susphy_quirk;
> + snps,dis_metastability_quirk;
> };
> };
>
> --
> cheers,
> -roger
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-02 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1527584458-6257-1-git-send-email-rogerq@ti.com>
2018-05-29 9:00 ` [PATCH 1/5] ARM: dts: dra7: Disable metastability workaround for USB2 Roger Quadros
2018-07-02 11:05 ` Tony Lindgren
2018-05-29 9:00 ` [PATCH 2/5] ARM: dts: am57xx-idk: Enable dual role for USB2 port Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).