From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:56362 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753827AbeGEQz3 (ORCPT ); Thu, 5 Jul 2018 12:55:29 -0400 Date: Thu, 5 Jul 2018 18:55:26 +0200 From: Greg Kroah-Hartman To: Ben Hutchings Cc: Keith Busch , Jianchao Wang , stable@vger.kernel.org, Sasha Levin , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4.4] nvme-pci: initialize queue memory before interrupts Message-ID: <20180705165526.GA4349@kroah.com> References: <20180613171320.GB28828@kroah.com> <20180619172306.atcqdzb2tdk3ivvt@xylophone.i.decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180619172306.atcqdzb2tdk3ivvt@xylophone.i.decadent.org.uk> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Jun 19, 2018 at 06:23:06PM +0100, Ben Hutchings wrote: > From: Keith Busch > > commit 161b8be2bd6abad250d4b3f674bdd5480f15beeb upstream. > > A spurious interrupt before the nvme driver has initialized the completion > queue may inadvertently cause the driver to believe it has a completion > to process. This may result in a NULL dereference since the nvmeq's tags > are not set at this point. > > The patch initializes the host's CQ memory so that a spurious interrupt > isn't mistaken for a real completion. > > Signed-off-by: Keith Busch > Reviewed-by: Johannes Thumshirn > Signed-off-by: Christoph Hellwig > [bwh: Backported to 4.4: adjust context] > Signed-off-by: Jens Axboe > --- > drivers/nvme/host/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Now applied, thanks. greg k-h