From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:43384 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753405AbeGERwY (ORCPT ); Thu, 5 Jul 2018 13:52:24 -0400 Date: Thu, 5 Jul 2018 19:52:21 +0200 From: Greg KH To: Ido Schimmel Cc: stable@vger.kernel.org, jslaby@suse.cz, davem@davemloft.net, jiri@mellanox.com Subject: Re: [PATCH 4.9] mlxsw: spectrum: Forbid linking of VLAN devices to devices that have uppers Message-ID: <20180705175221.GA29378@kroah.com> References: <20180705172452.1454-1-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180705172452.1454-1-idosch@mellanox.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jul 05, 2018 at 08:24:52PM +0300, Ido Schimmel wrote: > commit 25cc72a33835ed8a6f53180a822cadab855852ac upstream. > > Jiri Slaby noticed that the backport of upstream commit 25cc72a33835 > ("mlxsw: spectrum: Forbid linking to devices that have uppers") to > kernel 4.9.y introduced the same check twice in the same function > instead of in two different places. > > Fix this by relocating one of the checks to its intended place, thus > preventing unsupported configurations as described in the original > commit. > > Fixes: 73ee5a73e75f ("mlxsw: spectrum: Forbid linking to devices that have uppers") > Signed-off-by: Ido Schimmel > Reported-by: Jiri Slaby > --- > Greg, I read Documentation/stable_kernel_rules.txt, so I hope the patch > is fine. Please let me know if v2 is required. Thanks This commit is already in 4.9.51, why do you need/want it applied again? confused, greg k-h