From: Ido Schimmel <idosch@mellanox.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, jslaby@suse.cz, davem@davemloft.net,
jiri@mellanox.com
Subject: Re: [PATCH 4.9] mlxsw: spectrum: Forbid linking of VLAN devices to devices that have uppers
Date: Thu, 5 Jul 2018 21:23:47 +0300 [thread overview]
Message-ID: <20180705182347.GA3072@splinter> (raw)
In-Reply-To: <20180705175221.GA29378@kroah.com>
On Thu, Jul 05, 2018 at 07:52:21PM +0200, Greg KH wrote:
> On Thu, Jul 05, 2018 at 08:24:52PM +0300, Ido Schimmel wrote:
> > commit 25cc72a33835ed8a6f53180a822cadab855852ac upstream.
> >
> > Jiri Slaby noticed that the backport of upstream commit 25cc72a33835
> > ("mlxsw: spectrum: Forbid linking to devices that have uppers") to
> > kernel 4.9.y introduced the same check twice in the same function
> > instead of in two different places.
> >
> > Fix this by relocating one of the checks to its intended place, thus
> > preventing unsupported configurations as described in the original
> > commit.
> >
> > Fixes: 73ee5a73e75f ("mlxsw: spectrum: Forbid linking to devices that have uppers")
> > Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> > Reported-by: Jiri Slaby <jslaby@suse.cz>
> > ---
> > Greg, I read Documentation/stable_kernel_rules.txt, so I hope the patch
> > is fine. Please let me know if v2 is required. Thanks
>
> This commit is already in 4.9.51, why do you need/want it applied again?
It wasn't clear to me if I need to specify "commit <sha1> upstream" also
for fixes of backports. You want me to post v2 without this line?
Thanks
next prev parent reply other threads:[~2018-07-05 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 17:24 [PATCH 4.9] mlxsw: spectrum: Forbid linking of VLAN devices to devices that have uppers Ido Schimmel
2018-07-05 17:52 ` Greg KH
2018-07-05 18:23 ` Ido Schimmel [this message]
2018-07-05 18:29 ` Greg KH
2018-07-05 18:43 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705182347.GA3072@splinter \
--to=idosch@mellanox.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@mellanox.com \
--cc=jslaby@suse.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).