* [PATCH stable 4.4] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write()
@ 2018-07-10 16:33 Ian Abbott
2018-07-10 16:47 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Ian Abbott @ 2018-07-10 16:33 UTC (permalink / raw)
To: stable; +Cc: Greg Kroah-Hartman, Dan Carpenter, Ian Abbott, H Hartley Sweeten
From: Dan Carpenter <dan.carpenter@oracle.com>
[ Upstream commit 1376b0a2160319125c3a2822e8c09bd283cd8141 ]
There is a '>' vs '<' typo so this loop is a no-op.
Fixes: d35dcc89fc93 ("staging: comedi: quatech_daqp_cs: fix daqp_ao_insn_write()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e43139157d..769a94015117 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -642,7 +642,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
/* Make sure D/A update mode is direct update */
outb(0, dev->iobase + DAQP_AUX_REG);
- for (i = 0; i > insn->n; i++) {
+ for (i = 0; i < insn->n; i++) {
unsigned val = data[i];
int ret;
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH stable 4.4] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write()
2018-07-10 16:33 [PATCH stable 4.4] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write() Ian Abbott
@ 2018-07-10 16:47 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-10 16:47 UTC (permalink / raw)
To: Ian Abbott; +Cc: stable, Dan Carpenter, H Hartley Sweeten
On Tue, Jul 10, 2018 at 05:33:45PM +0100, Ian Abbott wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
>
> [ Upstream commit 1376b0a2160319125c3a2822e8c09bd283cd8141 ]
>
> There is a '>' vs '<' typo so this loop is a no-op.
>
> Fixes: d35dcc89fc93 ("staging: comedi: quatech_daqp_cs: fix daqp_ao_insn_write()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-10 16:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-10 16:33 [PATCH stable 4.4] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write() Ian Abbott
2018-07-10 16:47 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).