From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f67.google.com ([209.85.215.67]:34419 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387759AbeGKNzu (ORCPT ); Wed, 11 Jul 2018 09:55:50 -0400 Date: Wed, 11 Jul 2018 16:52:10 +0300 From: Serge Semin To: Christoph Hellwig Cc: ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org, okaya@codeaurora.org, chenhc@lemote.com, Sergey.Semin@t-platforms.ru, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method Message-ID: <20180711135210.GA18730@mobilestation> References: <20180709135713.8083-1-fancer.lancer@gmail.com> <20180709135713.8083-2-fancer.lancer@gmail.com> <20180711065631.GA21948@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180711065631.GA21948@infradead.org> Sender: stable-owner@vger.kernel.org List-ID: Hello Christoph, On Tue, Jul 10, 2018 at 11:56:31PM -0700, Christoph Hellwig wrote: > > + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow > > + * requests a cachable mapping with CWB attribute enabled. > > */ > > #define ioremap_cacheable_cow(offset, size) \ > > __ioremap_mode((offset), (size), _CACHE_CACHABLE_COW) > > This isn't actually used anywhere in the kernel tree. Please remove it > as well. I don't really know whether it is necessary at this point. We discarded the ioremap_uncached_accelerated() method, since the obvious alternative is now available: ioremap_wc(). While ioremap_cacheable_cow() hasn't got one. So if it was up to me, I'd leave it here. Anyway if the subsystem maintainers think otherwise, I won't refuse to submit a patch with this method removal. Regards, -Sergey