From: Greg KH <gregkh@linuxfoundation.org>
To: Scott Bauer <scott.bauer@intel.com>
Cc: stable@vger.kernel.org, Jon Derrick <jonathan.derrick@intel.com>,
Keith Busch <keith.busch@intel.com>
Subject: Re: [BACKPORT PATCH] nvme-pci: Remap CMB SQ entries on every controller reset
Date: Fri, 13 Jul 2018 14:01:04 +0200 [thread overview]
Message-ID: <20180713120104.GA20397@kroah.com> (raw)
In-Reply-To: <20180712212717.15318-1-scott.bauer@intel.com>
On Thu, Jul 12, 2018 at 03:27:17PM -0600, Scott Bauer wrote:
> Commit 815c6704bf9f1c59f3a6be380a4032b9c57b12f1 upstream.
>
> The controller memory buffer is remapped into a kernel address on each
> reset, but the driver was setting the submission queue base address
> only on the very first queue creation. The remapped address is likely to
> change after a reset, so accessing the old address will hit a kernel bug.
>
> This patch fixes that by setting the queue's CMB base address each time
> the queue is created.
>
> Fixes: f63572dff1421 ("nvme: unmap CMB and remove sysfs file in reset path")
> Reported-by: Christian Black <christian.d.black@intel.com>
> Cc: Jon Derrick <jonathan.derrick@intel.com>
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Scott Bauer <scott.bauer@intel.com>
> Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
> ---
> drivers/nvme/host/pci.c | 27 ++++++++++++++++-----------
> 1 file changed, 16 insertions(+), 11 deletions(-)
"backport" to where? What kernel tree(s) do you want this applied to?
I need a hint please...
thanks,
greg k-h
next prev parent reply other threads:[~2018-07-13 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 21:27 [BACKPORT PATCH] nvme-pci: Remap CMB SQ entries on every controller reset Scott Bauer
2018-07-12 22:14 ` Derrick, Jonathan
2018-07-13 12:01 ` Greg KH [this message]
2018-07-13 15:51 ` Keith Busch
2018-07-15 10:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713120104.GA20397@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jonathan.derrick@intel.com \
--cc=keith.busch@intel.com \
--cc=scott.bauer@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).