Re: request (x86 + stack protector + paravirt + clang)

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Jul 17, 2018 at 04:48:01PM -0700, Nick Desaulniers wrote:
> Please cherry-pick upstream commits:
> 
> d03db2b "compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline
> declarations"

This took a bunch of work to get it to work for 4.9, I didn't mess with
it for 4.4.y, can you provide a patch series for that tree?  Hm, I
wonder if the same commits I did for 4.9.y would work there, let me try
that first...

> 0e2e160 "x86/asm: Add _ASM_ARG* constants for argument registers to <asm/asm.h>"

This didn't work for 4.4.y either :(

> d0a8d93 "x86/paravirt: Make native_save_fl() extern inline"

This worked for all.

> To stable branches 4.4+.  They will allow 4.4+ x86 kernels compiled
> with Clang and have the configs CONFIG_STACK_PROTECTOR_STRONG and
> CONFIG_PARAVIRT to boot.  They also allow gcc 5.1+ users to have
> consistent `extern inline` semantics.
> 
> In response to:
> https://android-review.googlesource.com/c/kernel/common/+/716477#message-291621a3a8592fc5b4c2b8ae0f73c376ebd1a7b4
> 
> One of these days I'll remember to cc stable in the commit message
> properly...sorry!

Not a problem.

Also, a minor thing, when doing kernel work you should have:
	[core]
	       abbrev = 12

in your .gitconfig as our sha1 numbers are usually longer than the 7 you
sent above.

Also, here's a handy alias lots of us use:
	git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
to output the sha1 and commit description.

It would do this for one of your commits above:
	d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline")

thanks,

greg k-h