From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:45174 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730301AbeGRLdJ (ORCPT ); Wed, 18 Jul 2018 07:33:09 -0400 Date: Wed, 18 Jul 2018 12:55:46 +0200 From: Greg KH To: Mark Brown Cc: Amit Pundir , Stable , Jonas Gorski Subject: Re: [PATCH for-4.9.y 2/5] spi/bcm63xx: make spi subsystem aware of message size limits Message-ID: <20180718105546.GA29375@kroah.com> References: <1531815558-20002-1-git-send-email-amit.pundir@linaro.org> <1531815558-20002-3-git-send-email-amit.pundir@linaro.org> <20180718104718.GD5700@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180718104718.GD5700@sirena.org.uk> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jul 18, 2018 at 11:47:18AM +0100, Mark Brown wrote: > On Tue, Jul 17, 2018 at 01:49:15PM +0530, Amit Pundir wrote: > > From: Jonas Gorski > > > > commit 0135c03df914f0481c61f097c78d37cece84f330 upstream. > > > > The bcm63xx SPI controller does not allow manual control of the CS > > lines and will toggle it automatically before and after sending data, > > so we are limited to messages that fit in the FIFO buffer. Since the CS > > lines aren't available as GPIOs either, we will need to make slave > > drivers aware of this limitation so they can handle them accordingly. > > This seems a bit new featureish... It is? Reads like a bugfix to me to get crappy hardware to work properly :) Almost like a quirk addition. Anyway, it's a 9 line patch that the users of the hardware require to get it to work, is it a problem to add? thanks, greg k-h