From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from heliosphere.sirena.org.uk ([172.104.155.198]:37270 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726915AbeGRLv7 (ORCPT ); Wed, 18 Jul 2018 07:51:59 -0400 Date: Wed, 18 Jul 2018 12:14:31 +0100 From: Mark Brown To: Greg KH Cc: Amit Pundir , Stable , Jonas Gorski Subject: Re: [PATCH for-4.9.y 2/5] spi/bcm63xx: make spi subsystem aware of message size limits Message-ID: <20180718111431.GG5700@sirena.org.uk> References: <1531815558-20002-1-git-send-email-amit.pundir@linaro.org> <1531815558-20002-3-git-send-email-amit.pundir@linaro.org> <20180718104718.GD5700@sirena.org.uk> <20180718105546.GA29375@kroah.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V32M1hWVjliPHW+c" Content-Disposition: inline In-Reply-To: <20180718105546.GA29375@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: --V32M1hWVjliPHW+c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 18, 2018 at 12:55:46PM +0200, Greg KH wrote: > On Wed, Jul 18, 2018 at 11:47:18AM +0100, Mark Brown wrote: > > On Tue, Jul 17, 2018 at 01:49:15PM +0530, Amit Pundir wrote: > > > The bcm63xx SPI controller does not allow manual control of the CS > > > lines and will toggle it automatically before and after sending data, > > > so we are limited to messages that fit in the FIFO buffer. Since the CS > > > lines aren't available as GPIOs either, we will need to make slave > > > drivers aware of this limitation so they can handle them accordingly. > > This seems a bit new featureish... > It is? Reads like a bugfix to me to get crappy hardware to work > properly :) > Almost like a quirk addition. Yes, it is a quirk addition. > Anyway, it's a 9 line patch that the users of the hardware require to > get it to work, is it a problem to add? It's one of these cases where if someone notices the change it's because it causes the consumer driver to exercise code paths that they weren't otherwise exercising (for a little used feature too). If it were just in the driver perhaps but the actual use of the change would be in other code which makes it more risky. --V32M1hWVjliPHW+c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAltPIRYACgkQJNaLcl1U h9DOOQf/Rw967iOi6A8tUgXUPq8eZxB3uiTfXDYnBQcGBNx0WBa2HnVjoq30n1LU QvuOvlScom1RpAz6K6Kus3cCdI9K9BWC5YK0mu/2Vq/dEvZl4ijMHJ5Zfi+Ko4cA LFjrToILBxkwKWVVR0lgDduvy1um/Wo4siJUd/DegXFW3GBt4HC68f4DlQu+cI56 N6onurMEqRLf6tRETkMGsK8sTB0pl4P3VXHgy5Hl/QLQVn7J5wlWjeyF009so4uM /STV57N+kVYWShm2YOQ+aYIyzAwEgSKthglHm7SfkSHkeS3zjnMmYn43N/77AfNl mj+nG7SauJNLx4pOLYUjgehyQzes5Q== =D/zs -----END PGP SIGNATURE----- --V32M1hWVjliPHW+c--