From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:49470 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731035AbeGTO2K (ORCPT ); Fri, 20 Jul 2018 10:28:10 -0400 Date: Fri, 20 Jul 2018 15:39:46 +0200 From: Greg Kroah-Hartman To: Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jonas Gorski , Amit Pundir Subject: Re: [PATCH 4.9 11/66] spi/bcm63xx: make spi subsystem aware of message size limits Message-ID: <20180720133946.GA22550@kroah.com> References: <20180720121407.228772286@linuxfoundation.org> <20180720121407.910738439@linuxfoundation.org> <20180720123443.GF10784@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180720123443.GF10784@sirena.org.uk> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Jul 20, 2018 at 01:34:43PM +0100, Mark Brown wrote: > On Fri, Jul 20, 2018 at 02:13:28PM +0200, Greg Kroah-Hartman wrote: > > > The bcm63xx SPI controller does not allow manual control of the CS > > lines and will toggle it automatically before and after sending data, > > so we are limited to messages that fit in the FIFO buffer. Since the CS > > lines aren't available as GPIOs either, we will need to make slave > > drivers aware of this limitation so they can handle them accordingly. > > Same review comment as before: this will ask other code (which > presumably never worked?) to change how they use the hardware in order > to cope with the limiations which seems a bit risky to me given that > limits like this are fairly rare so that code isn't super well exercised > in general. Ok, now I think I understand this better. I've now dropped this, and the follow-on fixup patch from the 4.9 queue. Thanks for being patient with me. greg k-h