From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap.thunk.org ([74.207.234.97]:43194 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730087AbeGVSUu (ORCPT ); Sun, 22 Jul 2018 14:20:50 -0400 Date: Sun, 22 Jul 2018 13:23:20 -0400 From: "Theodore Y. Ts'o" To: Arnd Bergmann Cc: adilger.kernel@dilger.ca, jack@suse.cz, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, sirmy15@gmail.com, stable@vger.kernel.org, tgnottingham@gmail.com, y2038@lists.linaro.org Subject: Re: [PATCH v2 1/6] ext4: sysfs: print ext4_super_block fields as little-endian Message-ID: <20180722172320.GB6685@thunk.org> References: <20180711091414.1494843-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180711091414.1494843-1-arnd@arndb.de> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Jul 11, 2018 at 11:14:09AM +0200, Arnd Bergmann wrote: > While working on extended rand for last_error/first_error timestamps, > I noticed that the endianess is wrong, we access the little-endian > fields in struct ext4_super_block as native-endian when we print them. > > This adds a special case in ext4_attr_show() and ext4_attr_store() > to byteswap the superblock fields if needed. > > In older kernels, this code was part of super.c, it got moved to sysfs.c > in linux-4.4. > > Cc: stable@vger.kernel.org > Fixes: 52c198c6820f ("ext4: add sysfs entry showing whether the fs contains errors") > Reviewed-by: Andreas Dilger > Signed-off-by: Arnd Bergmann Applied, thanks. - Ted