From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:33974 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbeGXKR5 (ORCPT ); Tue, 24 Jul 2018 06:17:57 -0400 Date: Tue, 24 Jul 2018 11:12:25 +0200 From: Peter Zijlstra To: Cong Wang Cc: LKML , Ingo Molnar , Linus Torvalds , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , stable Subject: Re: [PATCH v2] perf/core: fix a possible deadlock scenario Message-ID: <20180724091225.GL2494@hirez.programming.kicks-ass.net> References: <20180719132834.GF18667@krava> <20180719191253.3843-1-xiyou.wangcong@gmail.com> <20180720115217.GQ2494@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jul 23, 2018 at 04:16:23PM -0700, Cong Wang wrote: > > > +#define PERF_EF_NO_WAIT 0x08 /* do not wait when stopping, for > > > + * example, waiting for a timer > > > + */ > > > > That's a broken comment style. > > It is picked by checkpatch.pl, not me, I chose a different one and got > a complain. :) Ignore checkpatch when it's wrong ;-)