From: Stefano Brivio <sbrivio@redhat.com>
To: "Philip Müller" <philm@manjaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, mochobb@clix.pt, manjaro@rlinhard.de
Subject: Re: [PATCH 4.14 12/53] cifs: Fix slab-out-of-bounds in send_set_info() on SMB2 ACE setting
Date: Thu, 26 Jul 2018 08:12:02 +1000 [thread overview]
Message-ID: <20180726081202.0f09a028@elisabeth> (raw)
In-Reply-To: <c4b62c9c-15e3-7957-a339-ca00b24dda02@manjaro.org>
On Wed, 25 Jul 2018 18:06:25 +0200
Philip Müller <philm@manjaro.org> wrote:
> Hi Greg, hi Stefano,
>
> seems adding "cifs: Fix slab-out-of-bounds in send_set_info() on SMB2
> ACE setting" (commit 748144f) [1] created a regression within linux
> v4.14 kernel series. Writing to a mounted cifs either freezes on writing
> or crashes the PC. A more detailed explanation you may find in our
> forums [2]. Reverting the patch, seems to "fix" it. Thoughts?
Hi Philip,
thanks for reporting this.
My bad, I didn't check how the backport of f46ecbd97f50 ("cifs: Fix
slab-out-of-bounds in send_set_info() on SMB2 ACE setting") looked like on
4.14. As 4.14 doesn't have commit 2fc803efe614 ("cifs: remove rfc1002
header from smb2_set_info_req"), the effect is substantially different.
Greg, I would need some time to check if we actually need this at all on
4.14, to do a proper backport in case and to run tests. Could you please
revert this on 4.14.y for the moment being? If a backport is needed, I'll
send it later on. Thanks!
--
Stefano
next prev parent reply other threads:[~2018-07-25 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 16:06 [PATCH 4.14 12/53] cifs: Fix slab-out-of-bounds in send_set_info() on SMB2 ACE setting Philip Müller
2018-07-25 22:12 ` Stefano Brivio [this message]
2018-07-26 10:22 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2018-07-10 18:24 [PATCH 4.14 00/53] 4.14.55-stable review Greg Kroah-Hartman
2018-07-10 18:24 ` [PATCH 4.14 12/53] cifs: Fix slab-out-of-bounds in send_set_info() on SMB2 ACE setting Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726081202.0f09a028@elisabeth \
--to=sbrivio@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=manjaro@rlinhard.de \
--cc=mochobb@clix.pt \
--cc=philm@manjaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox