From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:56616 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729254AbeGZLi5 (ORCPT ); Thu, 26 Jul 2018 07:38:57 -0400 Date: Thu, 26 Jul 2018 12:22:41 +0200 From: Greg Kroah-Hartman To: Stefano Brivio Cc: Philip =?iso-8859-1?Q?M=FCller?= , stable@vger.kernel.org, mochobb@clix.pt, manjaro@rlinhard.de Subject: Re: [PATCH 4.14 12/53] cifs: Fix slab-out-of-bounds in send_set_info() on SMB2 ACE setting Message-ID: <20180726102241.GA10499@kroah.com> References: <20180726081202.0f09a028@elisabeth> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180726081202.0f09a028@elisabeth> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jul 26, 2018 at 08:12:02AM +1000, Stefano Brivio wrote: > On Wed, 25 Jul 2018 18:06:25 +0200 > Philip M�ller wrote: > > > Hi Greg, hi Stefano, > > > > seems adding "cifs: Fix slab-out-of-bounds in send_set_info() on SMB2 > > ACE setting" (commit 748144f) [1] created a regression within linux > > v4.14 kernel series. Writing to a mounted cifs either freezes on writing > > or crashes the PC. A more detailed explanation you may find in our > > forums [2]. Reverting the patch, seems to "fix" it. Thoughts? > > Hi Philip, > > thanks for reporting this. > > My bad, I didn't check how the backport of f46ecbd97f50 ("cifs: Fix > slab-out-of-bounds in send_set_info() on SMB2 ACE setting") looked like on > 4.14. As 4.14 doesn't have commit 2fc803efe614 ("cifs: remove rfc1002 > header from smb2_set_info_req"), the effect is substantially different. > > Greg, I would need some time to check if we actually need this at all on > 4.14, to do a proper backport in case and to run tests. Could you please > revert this on 4.14.y for the moment being? If a backport is needed, I'll > send it later on. Thanks! Now reverted, thanks. greg k-h