From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:37491 "EHLO
        wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726979AbeHHLC7 (ORCPT
        <rfc822;stable@vger.kernel.org>); Wed, 8 Aug 2018 07:02:59 -0400
Date: Wed, 8 Aug 2018 10:44:13 +0200
From: Greg KH <greg@kroah.com>
To: Yongqin Liu <yongqin.liu@linaro.org>
Cc: stable@vger.kernel.org, Tom Gall <tom.gall@linaro.org>,
        Alistair Strachan <alistair.strachan@linaro.org>,
        Greg Kroah-Hartman <gregkh@google.com>,
        "avid S. Miller" <davem@davemloft.net>,
        John Stultz <john.stultz@linaro.org>,
        Thomas Egerer <hakke_007@gmx.de>,
        Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: Please help to apply commit 32b6170ca59c("ipv4+ipv6: Make
 INET*_ESP select CRYPTO_ECHAINIV")into the 4.4 stable kernel
Message-ID: <20180808084413.GB24734@kroah.com>
References: <CAMSo37VoCpVNJO14AaumTp_zLQp3WAHe54UEt4JV5hBVJ3SctA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMSo37VoCpVNJO14AaumTp_zLQp3WAHe54UEt4JV5hBVJ3SctA@mail.gmail.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Aug 08, 2018 at 04:19:10PM +0800, Yongqin Liu wrote:
> Hi, All
> Sorry, I am following the instructions in
> Documentation/networking/netdev-FAQ.txt to send out this mail,
> if I was wrong  or there are more things I need to do, please let me know.
> 
> After investigated on some failures of the android VtsKernelNetTest module test,
> I found that without the change of "ipv4+ipv6: Make INET*_ESP select
> CRYPTO_ECHAINIV",
> the config of CRYPTO_ECHAINIV will be generated as m by default in the
> .config file,
> which needs more module loading process to be done.
> But with the 4.9 and 4.14 kernels which have the change,
> CRYPTO_ECHAINIV will be generated as y by default in the .config file.
> 
> We could set config of CRYPTO_ECHAINIV to y explicitly to generated
> the correct .config file,

That would be the easiest solution here, right?  Why can you not do
that?

> but having the change of "ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV"
> cherry picked into the 4.4 stable kernel looks more like the right solution.
> 
> The commit id for that change is 32b6170ca59ccf07d0e394561e54b2cd9726038c,
> it's already in 4.9 and 4.14 kernels, like here:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/net/?h=linux-4.9.y&id=32b6170ca59ccf07d0e394561e54b2cd9726038c

Yes, because it showed up in 4.5 :)

Shouldn't your device configurations for 4.4 already be long done?  You
had better not be working on new systems with a 4.4 kernel, otherwise
you are in big trouble for many other reasons.  So your configuration
should already be finished so I fail to see how backporting this is
really going to solve anyone's problems.

thanks,

greg k-h