stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND] requests for xfs patches inclusion in 4.14.y
@ 2018-08-02  0:28 Eduardo Valentin
  2018-08-07 14:19 ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Eduardo Valentin @ 2018-08-02  0:28 UTC (permalink / raw)
  To: Greg KH, Stable; +Cc: Dave Chinner, Darrick J. Wong, Eric Sandeen

Greg,

Please consider adding the following XFS patches on linux-4.14.y branch
to fix NULL pointer dereference errors in lookup_slow() on a NULL inode->i_ops
and for a corrupted xfs image after xfs_da_shrink_inode():

ee457001ed6c ("xfs: catch inode allocation state mismatch corruption")
afca6c5b2595 ("xfs: validate cached inodes are free when allocated")
bb3d48dcf86a ("xfs: don't call xfs_da_shrink_inode with NULL bp")

Thanks.

-- 
All the best,
Eduardo Valentin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RESEND] requests for xfs patches inclusion in 4.14.y
  2018-08-02  0:28 [RESEND] requests for xfs patches inclusion in 4.14.y Eduardo Valentin
@ 2018-08-07 14:19 ` Greg KH
  2018-08-07 22:46   ` Dave Chinner
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2018-08-07 14:19 UTC (permalink / raw)
  To: Eduardo Valentin; +Cc: Stable, Dave Chinner, Darrick J. Wong, Eric Sandeen

On Wed, Aug 01, 2018 at 05:28:16PM -0700, Eduardo Valentin wrote:
> Greg,
> 
> Please consider adding the following XFS patches on linux-4.14.y branch
> to fix NULL pointer dereference errors in lookup_slow() on a NULL inode->i_ops
> and for a corrupted xfs image after xfs_da_shrink_inode():
> 
> ee457001ed6c ("xfs: catch inode allocation state mismatch corruption")
> afca6c5b2595 ("xfs: validate cached inodes are free when allocated")
> bb3d48dcf86a ("xfs: don't call xfs_da_shrink_inode with NULL bp")

Some of these also belong in 4.17...

Now queued up, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RESEND] requests for xfs patches inclusion in 4.14.y
  2018-08-07 14:19 ` Greg KH
@ 2018-08-07 22:46   ` Dave Chinner
  2018-08-08  6:35     ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Dave Chinner @ 2018-08-07 22:46 UTC (permalink / raw)
  To: Greg KH; +Cc: Eduardo Valentin, Stable, Darrick J. Wong, Eric Sandeen

On Tue, Aug 07, 2018 at 04:19:21PM +0200, Greg KH wrote:
> On Wed, Aug 01, 2018 at 05:28:16PM -0700, Eduardo Valentin wrote:
> > Greg,
> > 
> > Please consider adding the following XFS patches on linux-4.14.y branch
> > to fix NULL pointer dereference errors in lookup_slow() on a NULL inode->i_ops
> > and for a corrupted xfs image after xfs_da_shrink_inode():
> > 
> > ee457001ed6c ("xfs: catch inode allocation state mismatch corruption")
> > afca6c5b2595 ("xfs: validate cached inodes are free when allocated")
> > bb3d48dcf86a ("xfs: don't call xfs_da_shrink_inode with NULL bp")
> 
> Some of these also belong in 4.17...
> 
> Now queued up, thanks.

Who's tested the backports?

Cheers,

Dave.
-- 
Dave Chinner
dchinner@redhat.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RESEND] requests for xfs patches inclusion in 4.14.y
  2018-08-07 22:46   ` Dave Chinner
@ 2018-08-08  6:35     ` Greg KH
  2018-08-08  8:57       ` Dave Chinner
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2018-08-08  6:35 UTC (permalink / raw)
  To: Dave Chinner; +Cc: Eduardo Valentin, Stable, Darrick J. Wong, Eric Sandeen

On Wed, Aug 08, 2018 at 08:46:02AM +1000, Dave Chinner wrote:
> On Tue, Aug 07, 2018 at 04:19:21PM +0200, Greg KH wrote:
> > On Wed, Aug 01, 2018 at 05:28:16PM -0700, Eduardo Valentin wrote:
> > > Greg,
> > > 
> > > Please consider adding the following XFS patches on linux-4.14.y branch
> > > to fix NULL pointer dereference errors in lookup_slow() on a NULL inode->i_ops
> > > and for a corrupted xfs image after xfs_da_shrink_inode():
> > > 
> > > ee457001ed6c ("xfs: catch inode allocation state mismatch corruption")
> > > afca6c5b2595 ("xfs: validate cached inodes are free when allocated")
> > > bb3d48dcf86a ("xfs: don't call xfs_da_shrink_inode with NULL bp")
> > 
> > Some of these also belong in 4.17...
> > 
> > Now queued up, thanks.
> 
> Who's tested the backports?

In the previous thread for this series, Eduardo said that he did.

Eduardo, that is correct, right?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RESEND] requests for xfs patches inclusion in 4.14.y
  2018-08-08  6:35     ` Greg KH
@ 2018-08-08  8:57       ` Dave Chinner
  0 siblings, 0 replies; 5+ messages in thread
From: Dave Chinner @ 2018-08-08  8:57 UTC (permalink / raw)
  To: Greg KH; +Cc: Eduardo Valentin, Stable, Darrick J. Wong, Eric Sandeen

On Wed, Aug 08, 2018 at 08:35:29AM +0200, Greg KH wrote:
> On Wed, Aug 08, 2018 at 08:46:02AM +1000, Dave Chinner wrote:
> > On Tue, Aug 07, 2018 at 04:19:21PM +0200, Greg KH wrote:
> > > On Wed, Aug 01, 2018 at 05:28:16PM -0700, Eduardo Valentin wrote:
> > > > Greg,
> > > > 
> > > > Please consider adding the following XFS patches on linux-4.14.y branch
> > > > to fix NULL pointer dereference errors in lookup_slow() on a NULL inode->i_ops
> > > > and for a corrupted xfs image after xfs_da_shrink_inode():
> > > > 
> > > > ee457001ed6c ("xfs: catch inode allocation state mismatch corruption")
> > > > afca6c5b2595 ("xfs: validate cached inodes are free when allocated")
> > > > bb3d48dcf86a ("xfs: don't call xfs_da_shrink_inode with NULL bp")
> > > 
> > > Some of these also belong in 4.17...
> > > 
> > > Now queued up, thanks.
> > 
> > Who's tested the backports?
> 
> In the previous thread for this series, Eduardo said that he did.
> 
> Eduardo, that is correct, right?

Tested them on 4.14 or 4.17? Testing a backport on one kernel
version doesn't mean it'll be fine in all stable kernels...

Cheers,

Dave.
-- 
Dave Chinner
dchinner@redhat.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-08-08 11:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-02  0:28 [RESEND] requests for xfs patches inclusion in 4.14.y Eduardo Valentin
2018-08-07 14:19 ` Greg KH
2018-08-07 22:46   ` Dave Chinner
2018-08-08  6:35     ` Greg KH
2018-08-08  8:57       ` Dave Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).