From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: kys@linuxonhyperv.com To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, sthemmin@microsoft.com, Michael.H.Kelley@microsoft.com, vkuznets@redhat.com Cc: "K. Y. Srinivasan" , stable@vger.kernel.org Subject: [PATCH 1/5] Tools: hv: Fix a bug in the key delete code Date: Fri, 10 Aug 2018 23:06:07 +0000 Message-Id: <20180810230611.2114-1-kys@linuxonhyperv.com> In-Reply-To: <20180810230520.2055-1-kys@linuxonhyperv.com> References: <20180810230520.2055-1-kys@linuxonhyperv.com> Reply-To: kys@microsoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: From: "K. Y. Srinivasan" Fix a bug in the key delete code - the num_records range from 0 to num_records-1. Signed-off-by: K. Y. Srinivasan Reported-by: David Binderman Cc: --- tools/hv/hv_kvp_daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index dbf6e8bd98ba..bbb2a8ef367c 100644 --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@ -286,7 +286,7 @@ static int kvp_key_delete(int pool, const __u8 *key, int key_size) * Found a match; just move the remaining * entries up. */ - if (i == num_records) { + if (i == (num_records - 1)) { kvp_file_info[pool].num_records--; kvp_update_file(pool); return 0; -- 2.18.0