From: Greg KH <gregkh@linux-foundation.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: maowenan <maowenan@huawei.com>,
dwmw2@infradead.org, netdev@vger.kernel.org,
eric.dumazet@gmail.com, edumazet@google.com, davem@davemloft.net,
ycheng@google.com, jdw@amazon.de, stable@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)
Date: Thu, 16 Aug 2018 18:20:38 +0200 [thread overview]
Message-ID: <20180816162038.GA13451@kroah.com> (raw)
In-Reply-To: <20180816160616.u3refk4mqpyqagzi@unicorn.suse.cz>
On Thu, Aug 16, 2018 at 06:06:16PM +0200, Michal Kubecek wrote:
> > If not, we can go from there and evaluate this much larger patch
> > series. But let's try the simple thing first.
>
> At high packet rates (say 30K pkt/s and more), we can still saturate the
> CPU. This is also mentioned in the announcement with claim that switch
> to rbtree based queue would be necessary to fully address that. My tests
> seem to confirm that but I'm still not sure it is worth backporting
> something as intrusive into stable 4.4.
No, it is not. If you worry about those things, you should not be
running a 4.4 kernel, use 4.14 or newer please.
thanks,
greg k-h
next prev parent reply other threads:[~2018-08-16 19:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 2:50 [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390) Mao Wenan
2018-08-16 2:50 ` [PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()" Mao Wenan
2018-08-16 2:50 ` [PATCH stable 4.4 2/9] Revert "tcp: avoid collapses in tcp_prune_queue() if possible" Mao Wenan
2018-08-16 2:50 ` [PATCH stable 4.4 3/9] tcp: increment sk_drops for dropped rx packets Mao Wenan
2018-08-16 2:50 ` [PATCH stable 4.4 4/9] tcp: use an RB tree for ooo receive queue Mao Wenan
2018-08-16 2:50 ` [PATCH stable 4.4 5/9] tcp: free batches of packets in tcp_prune_ofo_queue() Mao Wenan
2018-08-16 2:50 ` [PATCH stable 4.4 6/9] tcp: avoid collapses in tcp_prune_queue() if possible Mao Wenan
2018-08-16 2:50 ` [PATCH stable 4.4 7/9] tcp: detect malicious patterns in tcp_collapse_ofo_queue() Mao Wenan
2018-08-16 2:50 ` [PATCH stable 4.4 8/9] tcp: call tcp_drop() from tcp_data_queue_ofo() Mao Wenan
2018-08-16 2:50 ` [PATCH stable 4.4 9/9] tcp: add tcp_ooo_try_coalesce() helper Mao Wenan
2018-08-16 6:16 ` [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390) Michal Kubecek
2018-08-16 6:42 ` maowenan
2018-08-16 6:52 ` Michal Kubecek
2018-08-16 7:19 ` maowenan
2018-08-16 7:23 ` Michal Kubecek
2018-08-16 7:39 ` maowenan
2018-08-16 7:44 ` Michal Kubecek
2018-08-16 7:55 ` maowenan
2018-08-16 11:39 ` Michal Kubecek
2018-08-16 12:05 ` maowenan
2018-08-16 12:33 ` Michal Kubecek
2018-08-16 15:24 ` Greg KH
2018-08-16 16:06 ` Michal Kubecek
2018-08-16 16:20 ` Greg KH [this message]
2018-08-17 2:48 ` maowenan
2018-09-13 12:32 ` Greg KH
2018-09-13 12:44 ` Eric Dumazet
2018-09-14 2:24 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816162038.GA13451@kroah.com \
--to=gregkh@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jdw@amazon.de \
--cc=maowenan@huawei.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox