From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com ([209.85.215.194]:36106 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbeHTToY (ORCPT ); Mon, 20 Aug 2018 15:44:24 -0400 Received: by mail-pg1-f194.google.com with SMTP id h17-v6so798881pgv.3 for ; Mon, 20 Aug 2018 09:28:06 -0700 (PDT) Date: Mon, 20 Aug 2018 10:28:00 -0600 From: Jason Gunthorpe To: Erez Shitrit Cc: Aaron Knister , RDMA mailing list , stable@vger.kernel.org, Ira Weiny , John Fleck , Feras Daoud Subject: Re: [PATCH v2] avoid race condition between start_xmit and cm_rep_handler Message-ID: <20180820162800.GA25543@ziepe.ca> References: <1534541486-16263-1-git-send-email-aaron.s.knister@nasa.gov> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Mon, Aug 20, 2018 at 09:36:53AM +0300, Erez Shitrit wrote: > Hi, > > Did you check the option to hold the netif_tx_lock_xxx() in > ipoib_cm_rep_handler function (over the line > set_bit(IPOIB_FLAG_OPER_UP)) instead of in the send data path flow? That does seem better, then the test_bit in the datapath could become non-atomic too :) Jason