stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 4.14 09/29] net: aquantia: Fix IFF_ALLMULTI flag functionality
Date: Tue, 21 Aug 2018 08:21:02 +0200	[thread overview]
Message-ID: <20180821055108.794634867@linuxfoundation.org> (raw)
In-Reply-To: <20180821055108.333930282@linuxfoundation.org>

4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>

[ Upstream commit 11ba961c916127651e12af6cad3891f8aeb25aa9 ]

It was noticed that NIC always pass all multicast traffic to the host
regardless of IFF_ALLMULTI flag on the interface.
The rule in MC Filter Table in NIC, that is configured to accept any
multicast packets, is turning on if IFF_MULTICAST flag is set on the
interface. It leads to passing all multicast traffic to the host.
This fix changes the condition to turn on that rule by checking
IFF_ALLMULTI flag as it should.

Fixes: b21f502f84be ("net:ethernet:aquantia: Fix for multicast filter handling.")
Signed-off-by: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c
+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c
@@ -752,7 +752,7 @@ static int hw_atl_b0_hw_packet_filter_se
 
 	rpfl2promiscuous_mode_en_set(self, IS_FILTER_ENABLED(IFF_PROMISC));
 	rpfl2multicast_flr_en_set(self,
-				  IS_FILTER_ENABLED(IFF_MULTICAST), 0);
+				  IS_FILTER_ENABLED(IFF_ALLMULTI), 0);
 
 	rpfl2_accept_all_mc_packets_set(self,
 					IS_FILTER_ENABLED(IFF_ALLMULTI));

  parent reply	other threads:[~2018-08-21  6:21 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-21  6:20 [PATCH 4.14 00/29] 4.14.66-stable review Greg Kroah-Hartman
2018-08-21  6:20 ` [PATCH 4.14 01/29] dccp: fix undefined behavior with cwnd shift in ccid2_cwnd_restart() Greg Kroah-Hartman
2018-08-21  6:20 ` [PATCH 4.14 02/29] l2tp: use sk_dst_check() to avoid race on sk->sk_dst_cache Greg Kroah-Hartman
2018-08-21  6:20 ` [PATCH 4.14 03/29] llc: use refcount_inc_not_zero() for llc_sap_find() Greg Kroah-Hartman
2018-08-21  6:20 ` [PATCH 4.14 04/29] net_sched: fix NULL pointer dereference when delete tcindex filter Greg Kroah-Hartman
2018-08-21  6:20 ` [PATCH 4.14 05/29] vsock: split dwork to avoid reinitializations Greg Kroah-Hartman
2018-08-21  6:20 ` [PATCH 4.14 06/29] net_sched: Fix missing res info when create new tc_index filter Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 07/29] vhost: reset metadata cache when initializing new IOTLB Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 08/29] ip6_tunnel: use the right value for ipv4 min mtu check in ip6_tnl_xmit Greg Kroah-Hartman
2018-08-21  6:21 ` Greg Kroah-Hartman [this message]
2018-08-21  6:21 ` [PATCH 4.14 10/29] ALSA: hda - Sleep for 10ms after entering D3 on Conexant codecs Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 11/29] ALSA: hda - Turn CX8200 into D3 as well upon reboot Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 12/29] ALSA: vx222: Fix invalid endian conversions Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 13/29] ALSA: virmidi: Fix too long output trigger loop Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 14/29] ALSA: cs5535audio: Fix invalid endian conversion Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 15/29] ALSA: hda: Correct Asrock B85M-ITX power_save blacklist entry Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 16/29] ALSA: memalloc: Dont exceed over the requested size Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 17/29] ALSA: vxpocket: Fix invalid endian conversions Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 18/29] USB: serial: sierra: fix potential deadlock at close Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 19/29] USB: serial: pl2303: add a new device id for ATEN Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 20/29] USB: option: add support for DW5821e Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 21/29] ACPI / PM: save NVS memory for ASUS 1025C laptop Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 22/29] tty: serial: 8250: Revert NXP SC16C2552 workaround Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 23/29] serial: 8250_exar: Read INT0 from slave device, too Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 24/29] serial: 8250_dw: always set baud rate in dw8250_set_termios Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 25/29] serial: 8250_dw: Add ACPI support for uart on Broadcom SoC Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 26/29] misc: sram: fix resource leaks in probe error path Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 27/29] Bluetooth: avoid killing an already killed socket Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 28/29] isdn: Disable IIOCDBGVAR Greg Kroah-Hartman
2018-08-21  6:21 ` [PATCH 4.14 29/29] cls_matchall: fix tcf_unbind_filter missing Greg Kroah-Hartman
2018-08-21 14:57 ` [PATCH 4.14 00/29] 4.14.66-stable review Guenter Roeck
2018-08-21 18:07 ` Naresh Kamboju
2018-08-21 19:49 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180821055108.794634867@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=dmitry.bogdanov@aquantia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).