Build failures in -stable queues

Build failures in -stable queues

[Guenter Roeck]

v4.4.y, v4.9.y:

Building mips:cavium_octeon_defconfig ... failed
--------------
Error log:

/opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c: In function 'octeon_mgmt_change_mtu':
/opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c:652:6: error: 'size_without_fcs' undeclared

v4.9.y, v4.14.y:

Building i386:tools/perf ... failed
Building x86_64:tools/perf ... failed
--------------
Error log:
   PERF_VERSION = 4.9.123.g5175d5
tests/parse-events.c: In function ‘test_event’:
tests/parse-events.c:1681:3: error: implicit declaration of function ‘parse_events_print_error’ [-Werror=implicit-function-declaration]
    parse_events_print_error(&err, e->name);
    ^
tests/parse-events.c:1681:3: error: nested extern declaration of ‘parse_events_print_error’

This is just a snapshot; builds are still ongoing. I'll send another e-mail later
if more errors are reported after the build is complete.

Guenter

Re: Build failures in -stable queues

[Greg Kroah-Hartman]

On Wed, Aug 22, 2018 at 06:41:50AM -0700, Guenter Roeck wrote:
> 
> v4.9.y, v4.14.y:
> 
> Building i386:tools/perf ... failed
> Building x86_64:tools/perf ... failed
> --------------
> Error log:
>   PERF_VERSION = 4.9.123.g5175d5
> tests/parse-events.c: In function ‘test_event’:
> tests/parse-events.c:1681:3: error: implicit declaration of function ‘parse_events_print_error’ [-Werror=implicit-function-declaration]
>    parse_events_print_error(&err, e->name);
>    ^
> tests/parse-events.c:1681:3: error: nested extern declaration of ‘parse_events_print_error’

Thanks, I've fixed this one.

Sasha, it would be good to add perf to your build tests so this doesn't
happen again.

greg k-h

Re: Build failures in -stable queues

[Sasha Levin]

On Wed, Aug 22, 2018 at 04:56:10PM +0200, Greg Kroah-Hartman wrote:
>On Wed, Aug 22, 2018 at 06:41:50AM -0700, Guenter Roeck wrote:
>>
>> v4.9.y, v4.14.y:
>>
>> Building i386:tools/perf ... failed
>> Building x86_64:tools/perf ... failed
>> --------------
>> Error log:
>>   PERF_VERSION = 4.9.123.g5175d5
>> tests/parse-events.c: In function ‘test_event’:
>> tests/parse-events.c:1681:3: error: implicit declaration of function ‘parse_events_print_error’ [-Werror=implicit-function-declaration]
>>    parse_events_print_error(&err, e->name);
>>    ^
>> tests/parse-events.c:1681:3: error: nested extern declaration of ‘parse_events_print_error’
>
>Thanks, I've fixed this one.
>
>Sasha, it would be good to add perf to your build tests so this doesn't
>happen again.
>
>greg k-h

Will do.

Re: Build failures in -stable queues

[Greg Kroah-Hartman]

On Wed, Aug 22, 2018 at 06:41:50AM -0700, Guenter Roeck wrote:
> v4.4.y, v4.9.y:
> 
> Building mips:cavium_octeon_defconfig ... failed
> --------------
> Error log:
> 
> /opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c: In function 'octeon_mgmt_change_mtu':
> /opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c:652:6: error: 'size_without_fcs' undeclared

Fixed this now too, thanks.

Sasha, how did this pass your build tests?

greg k-h

Re: Build failures in -stable queues

[Sasha Levin]

On Wed, Aug 22, 2018 at 05:00:39PM +0200, Greg Kroah-Hartman wrote:
>On Wed, Aug 22, 2018 at 06:41:50AM -0700, Guenter Roeck wrote:
>> v4.4.y, v4.9.y:
>>
>> Building mips:cavium_octeon_defconfig ... failed
>> --------------
>> Error log:
>>
>> /opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c: In function 'octeon_mgmt_change_mtu':
>> /opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c:652:6: error: 'size_without_fcs' undeclared
>
>Fixed this now too, thanks.
>
>Sasha, how did this pass your build tests?
>
>greg k-h

Hm, it looks like my mips allmodconfig/allyesconfig were failing with:

req: Cannot open input file certs/x509.genkey, No such file or directory
req: Use -help for summary.
/home/sasha/data/linux/certs/Makefile:48: recipe for target 'certs/signing_key.pem' failed
make[2]: *** [certs/signing_key.pem] Error 1
make[2]: *** Waiting for unfinished jobs....

so that build got blacklister. Guenter, do you see such errors in your
builds?

Re: Build failures in -stable queues

[Guenter Roeck]

On Wed, Aug 22, 2018 at 03:07:49PM +0000, Sasha Levin wrote:
> On Wed, Aug 22, 2018 at 05:00:39PM +0200, Greg Kroah-Hartman wrote:
> >On Wed, Aug 22, 2018 at 06:41:50AM -0700, Guenter Roeck wrote:
> >> v4.4.y, v4.9.y:
> >>
> >> Building mips:cavium_octeon_defconfig ... failed
> >> --------------
> >> Error log:
> >>
> >> /opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c: In function 'octeon_mgmt_change_mtu':
> >> /opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c:652:6: error: 'size_without_fcs' undeclared
> >
> >Fixed this now too, thanks.
> >
> >Sasha, how did this pass your build tests?
> >
> >greg k-h
> 
> Hm, it looks like my mips allmodconfig/allyesconfig were failing with:
> 
> req: Cannot open input file certs/x509.genkey, No such file or directory
> req: Use -help for summary.
> /home/sasha/data/linux/certs/Makefile:48: recipe for target 'certs/signing_key.pem' failed
> make[2]: *** [certs/signing_key.pem] Error 1
> make[2]: *** Waiting for unfinished jobs....
> 
> so that build got blacklister. Guenter, do you see such errors in your
> builds?

I don't build allyesconfig, but allmodconfig passed.
Maybe the build fails only with a more recent version of gcc ?
What version of gcc and binutils do you use for your tests ?

Note that you won't see the cavcium build error when building
allyesconfig/allmodconfig; that is why I am building it separately.

Guenter

---
Full build report for v4.9:

Build reference: v4.9.123-120-g5175d53
gcc version: mips-linux-gcc (GCC) 4.9.0

Building mips:defconfig ... passed
Building mips:allmodconfig ... passed
Building mips:allnoconfig ... passed
Building mips:bcm47xx_defconfig ... passed
Building mips:bcm63xx_defconfig ... passed
Building mips:nlm_xlp_defconfig ... passed
Building mips:ath79_defconfig ... passed
Building mips:ar7_defconfig ... passed
Building mips:e55_defconfig ... passed
Building mips:cavium_octeon_defconfig ... failed
Building mips:malta_defconfig ... passed
Building mips:rt305x_defconfig ... passed

Re: Build failures in -stable queues

[Sasha Levin]

On Wed, Aug 22, 2018 at 08:26:58AM -0700, Guenter Roeck wrote:
>On Wed, Aug 22, 2018 at 03:07:49PM +0000, Sasha Levin wrote:
>> On Wed, Aug 22, 2018 at 05:00:39PM +0200, Greg Kroah-Hartman wrote:
>> >On Wed, Aug 22, 2018 at 06:41:50AM -0700, Guenter Roeck wrote:
>> >> v4.4.y, v4.9.y:
>> >>
>> >> Building mips:cavium_octeon_defconfig ... failed
>> >> --------------
>> >> Error log:
>> >>
>> >> /opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c: In function 'octeon_mgmt_change_mtu':
>> >> /opt/buildbot/slave/stable-queue-4.4/build/drivers/net/ethernet/octeon/octeon_mgmt.c:652:6: error: 'size_without_fcs' undeclared
>> >
>> >Fixed this now too, thanks.
>> >
>> >Sasha, how did this pass your build tests?
>> >
>> >greg k-h
>>
>> Hm, it looks like my mips allmodconfig/allyesconfig were failing with:
>>
>> req: Cannot open input file certs/x509.genkey, No such file or directory
>> req: Use -help for summary.
>> /home/sasha/data/linux/certs/Makefile:48: recipe for target 'certs/signing_key.pem' failed
>> make[2]: *** [certs/signing_key.pem] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>>
>> so that build got blacklister. Guenter, do you see such errors in your
>> builds?
>
>I don't build allyesconfig, but allmodconfig passed.
>Maybe the build fails only with a more recent version of gcc ?
>What version of gcc and binutils do you use for your tests ?
>
>Note that you won't see the cavcium build error when building
>allyesconfig/allmodconfig; that is why I am building it separately.

Apparently when building *some* archs with module signing enabled and
using a "O=" external build dir, the build process won't copy over
certs/x509.genkey into the build dir and fail.

This doesn't seem to be a new issue, I'm looking into it...