From: Greg KH <gregkh@linuxfoundation.org>
To: arnd@arndb.de, pbonzini@redhat.com
Cc: stable@vger.kernel.org
Subject: Re: WTF: patch "[PATCH] x86: kvm: avoid unused variable warning" was seriously submitted to be applied to the 4.18-stable tree?
Date: Sat, 1 Sep 2018 14:37:15 -0700 [thread overview]
Message-ID: <20180901213714.GA6001@kroah.com> (raw)
In-Reply-To: <153583706369194@kroah.com>
On Sat, Sep 01, 2018 at 02:24:23PM -0700, gregkh@linuxfoundation.org wrote:
> The patch below was submitted to be applied to the 4.18-stable tree.
>
> I fail to see how this patch meets the stable kernel rules as found at
> Documentation/process/stable-kernel-rules.rst.
Oops, hit the wrong button, this should have been my "this did not
apply" message, sorry about that.
This doesn't apply because:
>
> I could be totally wrong, and if so, please respond to
> <stable@vger.kernel.org> and let me know why this patch should be
> applied. Otherwise, it is now dropped from my patch queues, never to be
> seen again.
>
> thanks,
>
> greg k-h
>
> ------------------ original commit in Linus's tree ------------------
>
> >From 7288bde1f9df6c1475675419bdd7725ce84dec56 Mon Sep 17 00:00:00 2001
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Mon, 20 Aug 2018 23:37:50 +0200
> Subject: [PATCH] x86: kvm: avoid unused variable warning
>
> Removing one of the two accesses of the maxphyaddr variable led to
> a harmless warning:
>
> arch/x86/kvm/x86.c: In function 'kvm_set_mmio_spte_mask':
> arch/x86/kvm/x86.c:6563:6: error: unused variable 'maxphyaddr' [-Werror=unused-variable]
>
> Removing the #ifdef seems to be the nicest workaround, as it
> makes the code look cleaner than adding another #ifdef.
>
> Fixes: 28a1f3ac1d0c ("kvm: x86: Set highest physical address bits in non-present/reserved SPTEs")
that commit is not in a stable tree. It wasn't marked to be backpoted,
should it?
thanks,
greg k-h
next prev parent reply other threads:[~2018-09-02 1:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-01 21:24 WTF: patch "[PATCH] x86: kvm: avoid unused variable warning" was seriously submitted to be applied to the 4.18-stable tree? gregkh
2018-09-01 21:37 ` Greg KH [this message]
2018-09-03 9:27 ` Arnd Bergmann
2018-09-04 19:17 ` Junaid Shahid
2018-09-13 7:19 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180901213714.GA6001@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).