Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <Alexander.Levin@microsoft.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH AUTOSEL 4.18 008/113] iommu/rockchip: Handle errors returned from PM framework
Date: Sun, 2 Sep 2018 12:56:21 +0000	[thread overview]
Message-ID: <20180902063932.GG35539@sasha-vm> (raw)
In-Reply-To: <86y3ckwdbi.wl-marc.zyngier@arm.com>

On Sun, Sep 02, 2018 at 08:47:29AM +0100, Marc Zyngier wrote:
>On Thu, 30 Aug 2018 19:01:16 +0100,
>Sasha Levin <Alexander.Levin@microsoft.com> wrote:
>>
>> From: Marc Zyngier <marc.zyngier@arm.com>
>>
>> [ Upstream commit 3fc7c5c0cff3150e471f5fd12f59971c6d2c6513 ]
>>
>> pm_runtime_get_if_in_use can fail: either PM has been disabled
>> altogether (-EINVAL), or the device hasn't been enabled yet (0).
>> Sadly, the Rockchip IOMMU driver tends to conflate the two things
>> by considering a non-zero return value as successful.
>>
>> This has the consequence of hiding other bugs, so let's handle this
>> case throughout the driver, with a WARN_ON_ONCE so that we can try
>> and work out what happened.
>>
>> Fixes: 0f181d3cf7d98 ("iommu/rockchip: Add runtime PM support")
>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> Signed-off-by: Olof Johansson <olof@lixom.net>
>> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
>
>Picking this patch on its own feels like a bad idea if CONFIG_PM is
>not selected. Consider picking up 7db7a8f5638a and d1558dfd9f22 which
>guarantee that things won't break.

Grabbed those 2 as well, thanks!

  reply	other threads:[~2018-09-02 17:12 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 18:01 [PATCH AUTOSEL 4.18 001/113] cifs: check if SMB2 PDU size has been padded and suppress the warning Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 002/113] hfsplus: don't return 0 when fill_super() failed Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 003/113] hfs: prevent crash on exit from failed search Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 004/113] sunrpc: Don't use stack buffer with scatterlist Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 005/113] fork: don't copy inconsistent signal handler state to child Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 006/113] fs/proc/vmcore.c: hide vmcoredd_mmap_dumps() for nommu builds Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 007/113] reiserfs: change j_timestamp type to time64_t Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 008/113] iommu/rockchip: Handle errors returned from PM framework Sasha Levin
2018-09-02  7:47   ` Marc Zyngier
2018-09-02 12:56     ` Sasha Levin [this message]
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 009/113] hfsplus: fix NULL dereference in hfsplus_lookup() Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 010/113] iommu/rockchip: Move irq request past pm_runtime_enable Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 011/113] fs/proc/kcore.c: use __pa_symbol() for KCORE_TEXT list entries Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 012/113] fat: validate ->i_start before using Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 013/113] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 014/113] workqueue: skip lockdep wq dependency in cancel_work_sync() Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 015/113] workqueue: re-add lockdep dependencies for flushing Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 016/113] scripts: modpost: check memory allocation results Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 017/113] apparmor: fix an error code in __aa_create_ns() Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 018/113] virtio: pci-legacy: Validate queue pfn Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 019/113] x86/mce: Add notifier_block forward declaration Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 020/113] i2c: core: ACPI: Make acpi_gsb_i2c_read_bytes() check i2c_transfer return value Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 021/113] IB/hfi1: Invalid NUMA node information can cause a divide by zero Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 022/113] pwm: meson: Fix mux clock names Sasha Levin
2018-08-30 18:01 ` [PATCH AUTOSEL 4.18 023/113] perf python: Fix pyrf_evlist__read_on_cpu() interface Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 024/113] powerpc/topology: Get topology for shared processors at boot Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 025/113] mm/list_lru.c: add memcg argument to list_lru_from_kmem() Sasha Levin
2018-08-30 21:38   ` Kirill Tkhai
2018-08-31 15:59     ` Greg Kroah-Hartman
2018-08-31 16:06       ` Sasha Levin
2018-08-31 16:05     ` Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 026/113] mm/fadvise.c: fix signed overflow UBSAN complaint Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 027/113] mm: make DEFERRED_STRUCT_PAGE_INIT explicitly depend on SPARSEMEM Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 028/113] fs/dcache.c: fix kmemcheck splat at take_dentry_name_snapshot() Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 029/113] platform/x86: intel_punit_ipc: fix build errors Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 030/113] bpf, sockmap: fix map elem deletion race with smap_stop_sock Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 031/113] tcp, ulp: fix leftover icsk_ulp_ops preventing sock from reattach Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 032/113] bpf, sockmap: fix sock_map_ctx_update_elem race with exist/noexist Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 033/113] net/xdp: Fix suspicious RCU usage warning Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 034/113] bpf, sockmap: fix leakage of smap_psock_map_entry Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 035/113] samples/bpf: all XDP samples should unload xdp/bpf prog on SIGTERM Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 036/113] netfilter: ip6t_rpfilter: set F_IFACE for linklocal addresses Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 037/113] s390/kdump: Fix memleak in nt_vmcoreinfo Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 038/113] ipvs: fix race between ip_vs_conn_new() and ip_vs_del_dest() Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 039/113] mfd: sm501: Set coherent_dma_mask when creating subdevices Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 040/113] netfilter: x_tables: do not fail xt_alloc_table_info too easilly Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 041/113] tracing: Handle CC_FLAGS_FTRACE more accurately Sasha Levin
2018-08-30 18:02 ` [PATCH AUTOSEL 4.18 042/113] platform/x86: asus-nb-wmi: Add keymap entry for lid flip action on UX360 Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 043/113] netfilter: fix memory leaks on netlink_dump_start error Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 044/113] tcp, ulp: add alias for all ulp modules Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 045/113] ubi: Initialize Fastmap checkmapping correctly Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 046/113] RDMA/hns: Fix usage of bitmap allocation functions return values Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 047/113] ACPICA: ACPICA: add status check for acpi_hw_read before assigning return value Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 048/113] perf arm spe: Fix uninitialized record error variable Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 049/113] net: hns3: Fix for command format parsing error in hclge_is_all_function_id_zero Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 050/113] block: don't warn for flush on read-only device Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 051/113] net: hns3: Fix for phy link issue when using marvell phy driver Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 052/113] PCI: Match Root Port's MPS to endpoint's MPSS as necessary Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 053/113] drm/amd/display: Guard against null crtc in CRC IRQ Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 054/113] coccicheck: return proper error code on fail Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 055/113] perf tools: Check for null when copying nsinfo Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 056/113] f2fs: avoid race between zero_range and background GC Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 057/113] f2fs: fix avoid race between truncate " Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 058/113] RISC-V: Use KBUILD_CFLAGS instead of KCFLAGS when building the vDSO Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 059/113] irqchip/stm32: Fix init error handling Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 060/113] irqchip/bcm7038-l1: Hide cpu offline callback when building for !SMP Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 061/113] net/9p/trans_fd.c: fix race by holding the lock Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 062/113] net/9p: fix error path of p9_virtio_probe Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 063/113] f2fs: fix to clear PG_checked flag in set_page_dirty() Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 064/113] pinctrl: axp209: Fix NULL pointer dereference after allocation Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 065/113] bpf: fix bpffs non-array map seq_show issue Sasha Levin
2018-08-30 18:03 ` [PATCH AUTOSEL 4.18 066/113] powerpc/uaccess: Enable get_user(u64, *p) on 32-bit Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180902063932.GG35539@sasha-vm \
    --to=alexander.levin@microsoft.com \
    --cc=marc.zyngier@arm.com \
    --cc=olof@lixom.net \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox