From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34198 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbeIETe1 (ORCPT ); Wed, 5 Sep 2018 15:34:27 -0400 Date: Wed, 5 Sep 2018 17:02:43 +0200 From: Greg KH To: Chas Williams <3chas3@gmail.com> Cc: stable@vger.kernel.org, mark.rutland@arm.com, natechancellor@gmail.com, Chas Williams Subject: Re: [PATCH] Fixes: Commit 2aa6d036b716 ("mm: numa: avoid waiting on freed migrated pages") Message-ID: <20180905150243.GB21619@kroah.com> References: <20180905085852.8122-1-3chas3@gmail.com> <20180905144317.9652-1-3chas3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180905144317.9652-1-3chas3@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Sep 05, 2018 at 10:43:17AM -0400, Chas Williams wrote: > From: Chas Williams > > Commit 2aa6d036b716 ("mm: numa: avoid waiting on freed migrated pages") > was an incomplete backport of the upstream commit. It is necessary to > always reset page_nid before attempting any early exit. > > The original commit conflicted due to lack of commit 82b0f8c39a38 > ("mm: join struct fault_env and vm_fault") in 4.9 so it wasn't a clean > application, and the change must have just gotten lost in the noise. > > Signed-off-by: Chas Williams > --- > mm/huge_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Much better, thanks! But can you cc: the people involved in that first patch to get their ack? Also, what about 4.4.y and 3.18.y which had the original commit backported as well? Do they also need this fix? thanks, greg k-h