From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-dm3nam03on0093.outbound.protection.outlook.com ([104.47.41.93]:48928 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725831AbeIGFAr (ORCPT ); Fri, 7 Sep 2018 01:00:47 -0400 From: Sasha Levin To: Sebastian Andrzej Siewior CC: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hans Verkuil , Mauro Carvalho Chehab Subject: Re: [PATCH AUTOSEL 4.18 023/131] media: usbtv: use irqsave() in USB's complete callback Date: Fri, 7 Sep 2018 00:22:43 +0000 Message-ID: <20180907002241.GA16300@sasha-vm> References: <20180902064601.183036-1-alexander.levin@microsoft.com> <20180902064601.183036-23-alexander.levin@microsoft.com> <20180903071631.phvvuwxu5ozstq6g@linutronix.de> In-Reply-To: <20180903071631.phvvuwxu5ozstq6g@linutronix.de> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Mon, Sep 03, 2018 at 09:16:32AM +0200, Sebastian Andrzej Siewior wrote: >On 2018-09-02 13:03:27 [+0000], Sasha Levin wrote: >> From: Sebastian Andrzej Siewior >> >> [ Upstream commit 320905baa1dbddd3991c287432176d536e1d5b79 ] >> >> The USB completion callback does not disable interrupts while acquiring >> the lock. We want to remove the local_irq_disable() invocation from >> __usb_hcd_giveback_urb() and therefore it is required for the callback >> handler to disable the interrupts while acquiring the lock. >> The callback may be invoked either in IRQ or BH context depending on the >> USB host controller. >> Use the _irqsave() variant of the locking primitives. >> >> Cc: Hans Verkuil >> Signed-off-by: Sebastian Andrzej Siewior >> Signed-off-by: Mauro Carvalho Chehab >> Signed-off-by: Sasha Levin > >This change (among the others that do the same in different drivers) >does not fix a bug; it is just needed for "other reasons". While this >series uncovered a few bugs, this is not one of them. >There is no need to backport this stable. Out it goes, thanks!=