From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-co1nam03on0132.outbound.protection.outlook.com ([104.47.40.132]:31072 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725831AbeIGFBT (ORCPT ); Fri, 7 Sep 2018 01:01:19 -0400 From: Sasha Levin To: Mark Brown CC: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Akshu Agrawal Subject: Re: [PATCH AUTOSEL 4.18 043/131] ASoC: soc-pcm: Use delay set in component pointer function Date: Fri, 7 Sep 2018 00:23:14 +0000 Message-ID: <20180907002313.GB16300@sasha-vm> References: <20180902064601.183036-1-alexander.levin@microsoft.com> <20180902064601.183036-43-alexander.levin@microsoft.com> <20180903111626.GC10302@sirena.org.uk> In-Reply-To: <20180903111626.GC10302@sirena.org.uk> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <570785E896CC5A429FB621208C7C9C14@namprd21.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Mon, Sep 03, 2018 at 12:16:26PM +0100, Mark Brown wrote: >On Sun, Sep 02, 2018 at 01:03:55PM +0000, Sasha Levin wrote: >> From: Akshu Agrawal >> >> [ Upstream commit 9fb4c2bf130b922c77c16a8368732699799c40de ] >> >> Take into account the base delay set in pointer callback. >> >> There are cases where a pointer function populates >> runtime->delay, such as: >> ./sound/pci/hda/hda_controller.c >> ./sound/soc/intel/atom/sst-mfld-platform-pcm.c > >I'm worried that if anyone notices this at all they will have already >compensated for the delays in userspace and therefore this will cause >them to see problems as they get double compenstation for delays. But what happens when they update to a newer Stable? They're going to hit that issue anyways.=