From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:43700 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726043AbeIGKWy (ORCPT ); Fri, 7 Sep 2018 06:22:54 -0400 Date: Fri, 7 Sep 2018 07:43:35 +0200 From: Greg Kroah-Hartman To: Sasha Levin Cc: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sebastian Andrzej Siewior Subject: Re: [PATCH AUTOSEL 4.9 01/43] usb: usbtest: use irqsave() in USB's complete callback Message-ID: <20180907054335.GC10250@kroah.com> References: <20180907003816.57852-1-alexander.levin@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180907003816.57852-1-alexander.levin@microsoft.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Sep 07, 2018 at 12:38:19AM +0000, Sasha Levin wrote: > From: Sebastian Andrzej Siewior > > [ Upstream commit 6f3fde684d0232e66ada3410f016a58e09a87689 ] > > The USB completion callback does not disable interrupts while acquiring > the lock. We want to remove the local_irq_disable() invocation from > __usb_hcd_giveback_urb() and therefore it is required for the callback > handler to disable the interrupts while acquiring the lock. > The callback may be invoked either in IRQ or BH context depending on the > USB host controller. > Use the _irqsave() variant of the locking primitives. > > Cc: Greg Kroah-Hartman > Acked-by: Alan Stern > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Sasha Levin > --- > drivers/usb/misc/usbtest.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) And dropped here :)