request for 4.4-stable: 86e1d5adcef96 ("net: ethernet: ti: cpsw: fix mdio device reference leak")

request for 4.4-stable: 86e1d5adcef96 ("net: ethernet: ti: cpsw: fix mdio device reference leak")

[SZ Lin (林上智)]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

Hi Greg,

This patch is not marked for 4.4-stable, but it's already in 4.9 and 4.14 stable. 

Please apply to 4.4-stable.

This patch fixed leak of mdio device reference.

--
SZ Lin (林上智)

[-- Attachment #2: 0001-net-ethernet-ti-cpsw-fix-mdio-device-reference-leak.patch --]
[-- Type: text/x-diff, Size: 1243 bytes --]

>From e5d91862fcc58a45fb8c7c4ae63f37b97ffde17f Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Thu, 17 Nov 2016 17:39:59 +0100
Subject: [PATCH] net: ethernet: ti: cpsw: fix mdio device reference leak

commit 86e1d5adcef961eb383ce4eacbe0ef22f06e2045 upstream

Make sure to drop the reference taken by of_find_device_by_node() when
looking up an mdio device from a phy_id property during probe.

Fixes: 549985ee9c72 ("cpsw: simplify the setup of the register
pointers")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
---
 drivers/net/ethernet/ti/cpsw.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index c1a4425b54e7..549f1f070eba 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2096,6 +2096,7 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data,
 			}
 			snprintf(slave_data->phy_id, sizeof(slave_data->phy_id),
 				 PHY_ID_FMT, mdio->name, phyid);
+			put_device(&mdio->dev);
 		} else {
 			dev_err(&pdev->dev, "No slave[%d] phy_id or fixed-link property\n", i);
 			goto no_phy_slave;
-- 
2.19.0

Re: request for 4.4-stable: 86e1d5adcef96 ("net: ethernet: ti: cpsw: fix mdio device reference leak")

[Greg Kroah-Hartman]

On Wed, Sep 12, 2018 at 08:49:40PM +0800, SZ Lin (林上智) wrote:
> Hi Greg,
> 
> This patch is not marked for 4.4-stable, but it's already in 4.9 and 4.14 stable. 
> 
> Please apply to 4.4-stable.
> 
> This patch fixed leak of mdio device reference.

Now applied, thanks.

greg k-h