From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f178.google.com ([209.85.210.178]:37149 "EHLO mail-pf1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726491AbeILRyG (ORCPT ); Wed, 12 Sep 2018 13:54:06 -0400 Received: by mail-pf1-f178.google.com with SMTP id h69-v6so976204pfd.4 for ; Wed, 12 Sep 2018 05:49:44 -0700 (PDT) Date: Wed, 12 Sep 2018 20:49:40 +0800 From: SZ Lin =?utf-8?B?KOael+S4iuaZuik=?= To: Greg Kroah-Hartman Cc: stable@vger.kernel.org Subject: request for 4.4-stable: 86e1d5adcef96 ("net: ethernet: ti: cpsw: fix mdio device reference leak") Message-ID: <20180912124940.GA9635@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Greg, This patch is not marked for 4.4-stable, but it's already in 4.9 and 4.14 stable. Please apply to 4.4-stable. This patch fixed leak of mdio device reference. -- SZ Lin (林上智) --fdj2RfSjLxBAspz7 Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-net-ethernet-ti-cpsw-fix-mdio-device-reference-leak.patch" Content-Transfer-Encoding: 8bit >>From e5d91862fcc58a45fb8c7c4ae63f37b97ffde17f Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Thu, 17 Nov 2016 17:39:59 +0100 Subject: [PATCH] net: ethernet: ti: cpsw: fix mdio device reference leak commit 86e1d5adcef961eb383ce4eacbe0ef22f06e2045 upstream Make sure to drop the reference taken by of_find_device_by_node() when looking up an mdio device from a phy_id property during probe. Fixes: 549985ee9c72 ("cpsw: simplify the setup of the register pointers") Signed-off-by: Johan Hovold Signed-off-by: David S. Miller Signed-off-by: SZ Lin (林上智) --- drivers/net/ethernet/ti/cpsw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index c1a4425b54e7..549f1f070eba 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -2096,6 +2096,7 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data, } snprintf(slave_data->phy_id, sizeof(slave_data->phy_id), PHY_ID_FMT, mdio->name, phyid); + put_device(&mdio->dev); } else { dev_err(&pdev->dev, "No slave[%d] phy_id or fixed-link property\n", i); goto no_phy_slave; -- 2.19.0 --fdj2RfSjLxBAspz7--