From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sn1nam02on0093.outbound.protection.outlook.com ([104.47.36.93]:16689 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727403AbeILWnh (ORCPT ); Wed, 12 Sep 2018 18:43:37 -0400 From: Sasha Levin To: Greg Kroah-Hartman CC: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sebastian Andrzej Siewior Subject: Re: [PATCH AUTOSEL 4.18 02/88] usb: usbtest: use irqsave() in USB's complete callback Date: Wed, 12 Sep 2018 17:38:02 +0000 Message-ID: <20180912173801.GD3821@sasha-vm> References: <20180907003547.57567-1-alexander.levin@microsoft.com> <20180907003547.57567-2-alexander.levin@microsoft.com> <20180907054223.GA10250@kroah.com> In-Reply-To: <20180907054223.GA10250@kroah.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Fri, Sep 07, 2018 at 07:42:23AM +0200, Greg Kroah-Hartman wrote: >On Fri, Sep 07, 2018 at 12:35:52AM +0000, Sasha Levin wrote: >> From: Sebastian Andrzej Siewior >> >> [ Upstream commit 6f3fde684d0232e66ada3410f016a58e09a87689 ] >> >> The USB completion callback does not disable interrupts while acquiring >> the lock. We want to remove the local_irq_disable() invocation from >> __usb_hcd_giveback_urb() and therefore it is required for the callback >> handler to disable the interrupts while acquiring the lock. >> The callback may be invoked either in IRQ or BH context depending on the >> USB host controller. >> Use the _irqsave() variant of the locking primitives. > >All of the "use irqsave in USB's complete callback" patches are not >stable material as they are prep work for changes that have yet to hit >Linus's tree. > >So you can drop this one. Now dropped. Thanks!=