From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-eopbgr680106.outbound.protection.outlook.com ([40.107.68.106]:17888 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727346AbeILWpH (ORCPT ); Wed, 12 Sep 2018 18:45:07 -0400 From: Sasha Levin To: Boris Ostrovsky CC: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , vkuznets , "David S . Miller" Subject: Re: [PATCH AUTOSEL 4.18 69/88] xen-netfront: fix queue name setting Date: Wed, 12 Sep 2018 17:39:29 +0000 Message-ID: <20180912173928.GE3821@sasha-vm> References: <20180907003547.57567-1-alexander.levin@microsoft.com> <20180907003547.57567-69-alexander.levin@microsoft.com> <5f24d66d-57d4-4424-d524-58a6d0687f02@oracle.com> In-Reply-To: <5f24d66d-57d4-4424-d524-58a6d0687f02@oracle.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <769A518D57A616489307372E555134A9@namprd21.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Fri, Sep 07, 2018 at 01:33:55PM -0400, Boris Ostrovsky wrote: >On 09/06/2018 08:36 PM, Sasha Levin wrote: >> From: Vitaly Kuznetsov >> >> [ Upstream commit 2d408c0d4574b01b9ed45e02516888bf925e11a9 ] >> >> Commit f599c64fdf7d ("xen-netfront: Fix race between device setup and >> open") changed the initialization order: xennet_create_queues() now >> happens before we do register_netdev() so using netdev->name in >> xennet_init_queue() is incorrect, we end up with the following in >> /proc/interrupts: >> >> 60: 139 0 xen-dyn -event eth%d-q0-tx >> 61: 265 0 xen-dyn -event eth%d-q0-rx >> 62: 234 0 xen-dyn -event eth%d-q1-tx >> 63: 1 0 xen-dyn -event eth%d-q1-rx >> >> and this looks ugly. Actually, using early netdev name (even when it's >> already set) is also not ideal: nowadays we tend to rename eth devices >> and queue name may end up not corresponding to the netdev name. >> >> Use nodename from xenbus device for queue naming: this can't change in V= M's >> lifetime. Now /proc/interrupts looks like >> >> 62: 202 0 xen-dyn -event device/vif/0-q0-tx >> 63: 317 0 xen-dyn -event device/vif/0-q0-rx >> 64: 262 0 xen-dyn -event device/vif/0-q1-tx >> 65: 17 0 xen-dyn -event device/vif/0-q1-rx >> >> Fixes: f599c64fdf7d ("xen-netfront: Fix race between device setup and op= en") >> Signed-off-by: Vitaly Kuznetsov >> Reviewed-by: Ross Lagerwall >> Signed-off-by: David S. Miller >> Signed-off-by: Sasha Levin > > >You also want to pull commit 21f2706b20100bb3db378461ab9b8e2035309b5b. Added, thanks!=