From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([23.128.96.9]:49932 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727278AbeIMUcn (ORCPT ); Thu, 13 Sep 2018 16:32:43 -0400 Date: Thu, 13 Sep 2018 08:22:43 -0700 (PDT) Message-Id: <20180913.082243.1622516360155710681.davem@davemloft.net> To: jgross@suse.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, stable@vger.kernel.org Subject: Re: [PATCH] xen/netfront: don't bug in case of too many frags From: David Miller In-Reply-To: <20180911070448.3958-1-jgross@suse.com> References: <20180911070448.3958-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: From: Juergen Gross Date: Tue, 11 Sep 2018 09:04:48 +0200 > Commit 57f230ab04d291 ("xen/netfront: raise max number of slots in > xennet_get_responses()") raised the max number of allowed slots by one. > This seems to be problematic in some configurations with netback using > a larger MAX_SKB_FRAGS value (e.g. old Linux kernel with MAX_SKB_FRAGS > defined as 18 instead of nowadays 17). > > Instead of BUG_ON() in this case just fall back to retransmission. > > Fixes: 57f230ab04d291 ("xen/netfront: raise max number of slots in xennet_get_responses()") > Cc: stable@vger.kernel.org > Signed-off-by: Juergen Gross Applied.