From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f172.google.com ([209.85.216.172]:45448 "EHLO mail-qt0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727881AbeIQTaw (ORCPT ); Mon, 17 Sep 2018 15:30:52 -0400 Received: by mail-qt0-f172.google.com with SMTP id g44-v6so15298751qtb.12 for ; Mon, 17 Sep 2018 07:03:23 -0700 (PDT) Date: Mon, 17 Sep 2018 07:03:17 -0700 From: Jakub Kicinski To: Sasha Levin Cc: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S . Miller" Subject: Re: [PATCH AUTOSEL 4.14 52/87] nfp: fail probe if serial or interface id is missing Message-ID: <20180917070317.19c09e88@cakuba.netronome.com> In-Reply-To: <20180917030220.245686-52-alexander.levin@microsoft.com> References: <20180917030220.245686-1-alexander.levin@microsoft.com> <20180917030220.245686-52-alexander.levin@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Mon, 17 Sep 2018 03:02:55 +0000, Sasha Levin wrote: > From: Jakub Kicinski > > [ Upstream commit 18aa5b180f00a10c2f63944b4f0ab116bf8ea19b ] > > On some platforms with broken ACPI tables we may not have access > to the Serial Number PCIe capability. This capability is crucial > for us for switchdev operation as we use serial number as switch ID, > and for communication with management FW where interface ID is used. > > If we can't determine the Serial Number we have to fail device probe. > > Signed-off-by: Jakub Kicinski > Signed-off-by: David S. Miller > Signed-off-by: Sasha Levin If the problem occurs the driver would usually fail to probe anyway (e.g. due to missing SR-IOV capability), just without providing any clear message why. So the patch is not of huge importance, but I'm not opposed to back porting it. I should've put this info in the commit message, my bad.