From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:42518 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729285AbeIRQch (ORCPT ); Tue, 18 Sep 2018 12:32:37 -0400 Date: Tue, 18 Sep 2018 12:00:51 +0100 From: Will Deacon To: Mikulas Patocka Cc: Sasha Levin , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace Message-ID: <20180918110051.GB16498@arm.com> References: <20180917030006.245495-1-alexander.levin@microsoft.com> <20180917030006.245495-32-alexander.levin@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Tue, Sep 18, 2018 at 06:55:34AM -0400, Mikulas Patocka wrote: > This patch is not correct, because the stacktrace is supposed to work > around discontiguous interrupt stacks. > > You should replace 'frame->fp <= fp' with 'frame->fp == fp'. No, just drop the patch. It was already reverted upstream in e87a4a92fba3. Can the AUTOSEL robot check for upstream reverts? Will