From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-eopbgr700136.outbound.protection.outlook.com ([40.107.70.136]:39456 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726000AbeITIN4 (ORCPT ); Thu, 20 Sep 2018 04:13:56 -0400 From: Sasha Levin To: Miquel Raynal CC: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Boris Brezillon Subject: Re: [PATCH AUTOSEL 4.18 10/92] mtd: rawnand: fscm: Avoid collision on PC def when compiling for MIPS Date: Thu, 20 Sep 2018 02:32:58 +0000 Message-ID: <20180920023257.GR3821@sasha-vm> References: <20180915012944.179481-1-alexander.levin@microsoft.com> <20180915012944.179481-10-alexander.levin@microsoft.com> <20180915192111.59105520@xps13> In-Reply-To: <20180915192111.59105520@xps13> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <9D57A790914B8249AF72F1A07F1F5454@namprd21.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Sat, Sep 15, 2018 at 07:21:11PM +0200, Miquel Raynal wrote: >Hi Sasha, > >Sasha Levin wrote on Sat, 15 Sep 2018 >01:29:55 +0000: > >> From: Boris Brezillon >> >> [ Upstream commit 8f3931ed975e1d775b87ce85d65ecacd54138359 ] >> >> We want to allow this driver to be selected when COMPILE_TEST=3Dy, this >> means the driver can be compiled for any arch, including MIPS. When >> compiling this driver for MIPS, we end up with a collision on the 'PC' >> macro definition (also defined in arch/mips/include/asm/ptrace.h). >> >> Prefix the fsmc one with FSMC_ to avoid this problem. >> >> Signed-off-by: Boris Brezillon >> Signed-off-by: Miquel Raynal >> Signed-off-by: Sasha Levin > >I don't know what the exact policy is regarding backporting patches to >stable but this one, while harmless, will have no effect on >stable kernels AFAICT because it fixes issues discovered when allowing >COMPILE_TEST on a few drivers, which is a change that is not going to be >stable materials anyway. > >Same situation for: >[PATCH AUTOSEL 4.18 11/92] mtd: rawnand: sunxi: Add an U suffix to NFC_PA= GE_OP definition >[PATCH AUTOSEL 4.14 08/57] mtd: rawnand: sunxi: Add an U suffix to NFC_PA= GE_OP definition >[PATCH AUTOSEL 4.9 04/34] mtd: rawnand: sunxi: Add an U suffix to NFC_PAG= E_OP definition >[PATCH AUTOSEL 4.4 04/20] mtd: rawnand: sunxi: Add an U suffix to NFC_PAG= E_OP definition I'll drop it from all branches. Thanks!=