From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:36343 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726954AbeITQz7 (ORCPT ); Thu, 20 Sep 2018 12:55:59 -0400 Date: Thu, 20 Sep 2018 20:12:55 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: LKML , Andrew Morton , stable@vger.kernel.org Subject: Re: [PATCH] zram: fix missing zero pages for memory tracking Message-ID: <20180920111255.GA31303@rodete-laptop-imager.corp.google.com> References: <20180919051846.234615-1-minchan@kernel.org> <20180919072916.GA1180@jagdpanzerIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180919072916.GA1180@jagdpanzerIV> Sender: stable-owner@vger.kernel.org List-ID: Hi Sergey, On Wed, Sep 19, 2018 at 04:29:16PM +0900, Sergey Senozhatsky wrote: > On (09/19/18 14:18), Minchan Kim wrote: > > We need to count zero filled pages as well as other pages in zram. > > A nit, > > 'ZRAM_FLAG_SHIFT + 1' covers all ZRAM_SAME pages, not only > zero filled pages. Yub, that's what I want. Currently, it covers only non-zero filled same page, which is inconsistent and user easily miss zero-filled same page.