From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-eopbgr720113.outbound.protection.outlook.com ([40.107.72.113]:21340 "EHLO NAM05-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727392AbeIUUr7 (ORCPT ); Fri, 21 Sep 2018 16:47:59 -0400 From: Sasha Levin To: Will Deacon CC: Mikulas Patocka , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace Date: Fri, 21 Sep 2018 14:58:42 +0000 Message-ID: <20180921145840.GT3821@sasha-vm> References: <20180917030006.245495-1-alexander.levin@microsoft.com> <20180917030006.245495-32-alexander.levin@microsoft.com> <20180918110051.GB16498@arm.com> In-Reply-To: <20180918110051.GB16498@arm.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Tue, Sep 18, 2018 at 12:00:51PM +0100, Will Deacon wrote: >On Tue, Sep 18, 2018 at 06:55:34AM -0400, Mikulas Patocka wrote: >> This patch is not correct, because the stacktrace is supposed to work >> around discontiguous interrupt stacks. >> >> You should replace 'frame->fp <=3D fp' with 'frame->fp =3D=3D fp'. > >No, just drop the patch. It was already reverted upstream in >e87a4a92fba3. Can the AUTOSEL robot check for upstream reverts? It does! Once when it grabs the patch and once right before Greg sees a pull request. There's a (rather large - ~2 week) time gap in between when fixes/reverts sneak in. Thanks for the review, I'll drop the patch. -- Thanks, Sasha=